search

vuetifyjs / nuxt

Nuxt.js + Vuetify.js starter project template.
MIT License
306 stars 109 forks source link

[Bug Report] Test of VOverflowBtn not correct #86

Closed borisdayma closed 5 years ago

borisdayma commented 5 years ago

Versions and Environment

Vuetify: 2.0.0-alpha.10 Vue: 2.6.10 Browsers: Chrome 73.0.3683.75 OS: Windows 10

Steps to reproduce

Pull request #6797 was merged, however an error was introduced: see line 41 of VOverflowBtn.spec.ts in pull request diff.

Expected Behavior

The test "segmented - should warn when item has no callback" should be executed switching from one item with callback to one item without as previously.

Actual Behavior

Both items have no callback and the warning is tipped. However, this is an easier test than when switching between 2 items.

Reproduction Link

https://github.com/borisdayma/vuetify/tree/tests/VOverflowBtn

Other comments

When simply changing back first item to { text: 'Hello', callback: () => {} }, the test does not pass.

borisdayma commented 5 years ago

I put it in the wrong package. Moved issue to https://github.com/vuetifyjs/vuetify/issues/6810