search

vuetifyjs / vue-cli-plugins

🔌 A collection of Vuetify plugins for Vue CLI
https://vuetifyjs.com/en/getting-started/quick-start#vue-cli-3
Other
428 stars 113 forks source link

fix(dependencies): add undeclared dependencies #155

Closed paul-soporan closed 4 years ago

paul-soporan commented 4 years ago

vue-cli-plugin-vuetify depends on semver, but doesn't declare it as a dependency, which causes Yarn 2 PnP to throw Error: A package is trying to access another package without the second one being listed as a dependency of the first one when used inside a project.

This PR adds semver as a dependency to vue-cli-plugin-vuetify, as well as to @vuetify/cli-plugin-utils (since I've noticed it has the same issue).

This PR preserves the version of semver (^6.3.0) that is declared as a devDependency in the root package.json(I didn't remove it because I'm not sure if it is used anywhere else).

DRoet commented 4 years ago

nice work, I think this also needs the sass-loader (optional peer-deps) and vuetify-loader (not sure if optional) as dependencies

paul-soporan commented 4 years ago

Done. sass-loader has been added as an optional peer dependency to @vuetify/cli-plugin-utils(https://github.com/vuetifyjs/vue-cli-plugins/blob/6f4321d6fa6b9707718f7c3a7b444cf9d32e42c5/packages/cli-plugin-utils/index.js#L97) and to vue-cli-plugin-vuetify(https://github.com/vuetifyjs/vue-cli-plugins/blob/6f4321d6fa6b9707718f7c3a7b444cf9d32e42c5/packages/vue-cli-plugin-vuetify/util/helpers.js#L51). vuetify-loader has been added as an optional peer dependency to vue-cli-plugin-vuetify(https://github.com/vuetifyjs/vue-cli-plugins/blob/6f4321d6fa6b9707718f7c3a7b444cf9d32e42c5/packages/vue-cli-plugin-vuetify/index.js#L14).