Removed deprecated null-loader dependency

vuetifyjs / vue-cli-plugins

🔌 A collection of Vuetify plugins for Vue CLI

https://vuetifyjs.com/en/getting-started/quick-start#vue-cli-3

Other

427 stars 113 forks source link

Removed deprecated null-loader dependency #266

Closed lgarczyn closed 3 years ago

lgarczyn commented 3 years ago

Note: absolutely not tested, not familiar with chain-webpack, etc.

This should fix: https://github.com/vuetifyjs/vue-cli-plugins/issues/254

Relevant: https://github.com/vuetifyjs/vue-cli-plugins/pull/152

The chain webpack types don't seem to thing that an alias can be false, it appears that they are not up to date with webpack on this: https://webpack.js.org/configuration/resolve/#resolvealias

I thought I'd give it a try, but this is a bit out of my league

lgarczyn commented 3 years ago

Did you test this? Cause I didn't

ElijahKotyluk commented 3 years ago

Yes, this was tested and it works fine. I merged it into dev, so it will be out in the next release. Looking to have a webpack 5 upgrade by then as well.

Thank you for your contribution.