vuetifyjs / vue-cli-plugins

🔌 A collection of Vuetify plugins for Vue CLI
https://vuetifyjs.com/en/getting-started/quick-start#vue-cli-3
Other
427 stars 113 forks source link

Add webpack as peerDependency in vue-cli-plugin-vuetify #318

Closed viell-dev closed 2 years ago

viell-dev commented 2 years ago

null-loader has webpack as a peerDependency. Therefore vue-cli-plugin-vuetify should either provide webpack itself or also declare it as a peerDependency.

Yarn (berry) will notify the user about this:

➤ YN0002: │ vue-cli-plugin-vuetify@npm:2.4.6 [4afbd] doesn't provide webpack (pb29af), requested by null-loader

Just copying this from null-loader's package.json into yours would remove the message for consumers.

  "peerDependencies": {
    "webpack": "^4.0.0 || ^5.0.0"
  },

If the consumer project doesn't depend on webpack then yarn will notify about that instead.

➤ YN0002: │ vue-cli-plugins-yarn-test@workspace:. doesn't provide webpack (p33206), requested by vue-cli-plugin-vuetify

When the notice is about the current workspace the user can actually do something about it. (without forking)

viell-dev commented 2 years ago

Solved by #319