search

vuetifyjs / vuetify-loader

📦 Webpack and Vite plugins for treeshaking Vuetify components and more
https://vuetifyjs.com/customization/a-la-carte#vuetify-loader
MIT License
511 stars 91 forks source link

fix: change style plugin prefix for nuxt #328

Closed franz-bendezu closed 3 months ago

franz-bendezu commented 9 months ago

Changes

This pull request addresses the issue mentioned in #313 by making a specific and focused change to the plugin. The primary modification involves updating the prefix to resolve the sourcemap and Nuxt loading issues.

Objectives

  1. Bug Fix: Resolve the sourcemap bug caused by the \0 prefix, ensuring compatibility with Nuxt builds.
  2. Enhancement: Improve the virtual prefix for better integration with Nuxt's main pattern.

Context

The original pull request #313 aimed to achieve multiple objectives, but feedback from the maintainers highlighted the need for a more focused change. This new pull request isolates the modification to the prefix, aiming to keep the scope concise and targeted.

Related Issues

franz-bendezu commented 9 months ago

After testing, this change successfully resolves the issue of stuck loading and adds support for inline styles via SSR. I am currently investigating the cause of the sourcemap warning during server build start.

shawn-mty commented 5 months ago

What's going on with this? @franz-bendezu

shawn-mty commented 5 months ago

@johnleider 🙏

Fixing this will help everyone who uses Nuxt. Please help🙏

https://github.com/vuetifyjs/vuetify-loader/issues/290

franz-bendezu commented 5 months ago

What's going on with this? @franz-bendezu

I have seen more changes in the repository and I have not had time these months, on the weekend I will review it in detail

shawn-mty commented 5 months ago

What's going on with this? @franz-bendezu

I have seen more changes in the repository and I have not had time these months, on the weekend I will review it in detail

Thanks boss, appreciate you!

adamskeeled commented 4 months ago

Any updates regarding this?

adamskeeled commented 3 months ago

@KaelWD @johnleider Apologies for bothering you about this, but any idea when this can be reviewed and possibly merged? Or if it's not gonna happen anytime soon, any short-term solution I can do on my side while this doesn't get merged? Thanks in advance!