search

vuetifyjs / vuetify

🐉 Vue Component Framework
https://vuetifyjs.com
MIT License
39.62k stars 6.95k forks source link

[Bug Report][3.5.14] VTimePicker updates models very lazy #19545

Open KIDS-interactive opened 5 months ago

KIDS-interactive commented 5 months ago

Environment

Vuetify Version: 3.5.14 Last working version: 2.7.2 Vue Version: 3.4.21 Browsers: Chrome 123.0.0.0 OS: Windows 10

Steps to reproduce

The timePicker doesnt trigger an model-update or an hour update very often. In vuetify2 it was updated on every scroll and click, so the user could confirm or abort. Now there is only an v-model update on hour and minute confirmation.

Expected Behavior

update:hour and update:minute triggers on every visible change. v-model updates on every visible change

Actual Behavior

v-model updates only after hour and minute selection update:hour and update:minute triggers only on click

Reproduction Link

https://play.vuetifyjs.com/#...

In Vuetify2: https://v2.vuetifyjs.com/en/components/time-pickers/#dialog-and-menu Click on "Dialog" - here you can confirm with "ok" - the model was updated more frequently (you can see it in the input-field)

chrislol98 commented 5 months ago

cant trigger update:minute, theres got to be some bugs

KIDS-interactive commented 5 months ago

i suggest to use an debounced call on update, so you don't have too few or too many updates on the model

blalan05 commented 5 months ago

cant trigger update:minute, theres got to be some bugs

This PR fixes that.

KIDS-interactive commented 5 months ago

@blalan05 Unfortunately, still no update is triggered when you scroll. Could you implement this with an debounce? And thanks for your effort!

https://play.vuetifyjs.com/#...

https://github.com/vuetifyjs/vuetify/assets/75635412/c17a8b0b-f3b2-419b-98db-76540aef2838

m2xilon commented 4 months ago

@blalan05 currently selecting a different hour but same minute will not trigger @update:model-value either. playground example

https://github.com/vuetifyjs/vuetify/assets/121069425/05406f72-53b4-47b3-b9dc-c8f2354defc2

Additionally getting the following when updating to a different time to the one currently set image

Maqsyo commented 4 months ago

@blalan05 is there any plan to fix this issue soon? 🙈

benwick commented 2 months ago

@blalan05 Any progress on this issue?

KIDS-interactive commented 2 months ago

@KaelWD is there any plan to release this component? Would you accept an bounty to focus on this?

KIDS-interactive commented 1 month ago

@johnleider Maybe you can help?

blalan05 commented 1 month ago

I think this PR may fix this, I've changed how and when it emits the value, #20179