search

vuetifyjs / vuetify

🐉 Vue Component Framework
https://vuetifyjs.com
MIT License
39.06k stars 6.91k forks source link

[Bug Report][master branch] Possible bug where string values are passed as transition hooks #19617

Closed yyx990803 closed 2 weeks ago

yyx990803 commented 2 weeks ago

Environment

Vuetify Version: latest master Vue Version: latest main (soon to be released 3.4.22) Browsers: Chrome 123.0.0.0 OS: Mac OS 10.15.7

Steps to reproduce

This is discovered in Vue core ecosystem-ci after merging https://github.com/vuejs/core/pull/8953

See linked ecosystem-ci log for the test cases affected.

Expected Behavior

No string values passed to onBeforeEnter hook

Actual Behavior

String values are passed to onBeforeEnter hook

Reproduction Link

https://github.com/vuejs/ecosystem-ci/actions/runs/8692149431/job/23836077334

KaelWD commented 2 weeks ago

We're passing functions not strings, this is a transition-group-stub from vue-test-utils.

https://github.com/vuetifyjs/vuetify/blob/0a9a2bb9df59c9a35301aba98375f8c5d1fe0090/packages/vuetify/src/components/transitions/createTransition.ts#L74-L79

alecgibson commented 2 weeks ago

I've opened https://github.com/vuejs/test-utils/issues/2411