vuetifyjs / vuetify

🐉 Vue Component Framework
https://vuetifyjs.com
MIT License
39.06k stars 6.91k forks source link

[Bug Report][3.5.16] V-defaults-Provider does not work on V-Dialog #19645

Open tomfree opened 2 weeks ago

tomfree commented 2 weeks ago

Environment

Vuetify Version: 3.5.16 Vue Version: 3.4.23 Browsers: Chrome 123.0.0.0 OS: Windows 10

Steps to reproduce

Click on button "Click" and compare the VCards in the different colors

Expected Behavior

V-Card in V-Dialog should have rounded=="xl" applied as the V-dialog is within the v-defaults-provider

Actual Behavior

VCArd in V-Dialog uses rounded=='lg' and ignores the v-defaults-provider

Reproduction Link

https://play.vuetifyjs.com/#...

Other comments

See 1.) V-Card outside of v-defaults-provider to use rounded=='lg' which is correct 2.) V-Card inside of v-defaults-provider but outside of v-dialog to use rounded=='xl' which is correct 3.) V-Card inside of v-defaults-provider and inside of v-dialog to use rounded=='lg' which is incorrect as v-defaults-provider is not used here

johnleider commented 1 week ago

This is happening because we change the root here https://github.com/vuetifyjs/vuetify/blob/3d810e1f9a5eadfcf1b4641c8d969b02a9bc0a79/packages/vuetify/src/components/VDialog/VDialog.tsx#L143

Is there any thing we can do to hook into this @KaelWD?

KaelWD commented 1 week ago

15777