search

vuetifyjs / vuetify

🐉 Vue Component Framework
https://vuetifyjs.com
MIT License
39.11k stars 6.92k forks source link

feat(VSlider): reverse property for VSlider allows for max on left and min on right #7215

Closed sureshvv closed 4 years ago

sureshvv commented 5 years ago

Description

Motivation and Context

How Has This Been Tested?

Markup:

```vue // Paste your FULL Playground.vue here ```

Types of changes

Checklist:

jacekkarczmarczyk commented 5 years ago

Why not just check if max < min instead of adding a new prop?

DRoet commented 5 years ago

Why not just check if max < min instead of adding a new prop?

yeah that would be pretty neat, altho it would kind of defeat the purpose of "max" and "min" as concepts. maybe the props should've been called start and end 🤷‍♂

sureshvv commented 5 years ago

Why not just check if max < min instead of adding a new prop?

yeah that would be pretty neat, altho it would kind of defeat the purpose of "max" and "min" as concepts. maybe the props should've been called start and end

or left and right would be even better :D

sureshvv commented 5 years ago

Screenshot from 2019-03-23 11-35-09

This is to give you an idea of why it may be useful. Or if you know how this can be done without a new property.

jacekkarczmarczyk commented 5 years ago

@sureshvv Where would you display left value in RTL? On the left (like in LTR) or on the right?

sureshvv commented 5 years ago

@sureshvv Where would you display left value in RTL? On the left (like in LTR) or on the right?

The beauty of left and right is they don't change with rtl. Left is left is left.

jacekkarczmarczyk commented 5 years ago

And the cons are that

sureshvv commented 5 years ago

And the cons are that

  • you'll need another props for vertical slider (there's no left/right)
  • i'm not sure about this, so correct me if i'm wrong, but i guess that the default layout in RTL mode is just the mirror image of LTR, so in multilanguage site if you want to switch from LTR to RTL you'll need to switch left and right values

  1. yep.. may be top and bottom for vertical sliders

  2. yep.. we are punting on rtl and let the individual programmer worry about it - but it may be all right for most users. not really sure about that though :)

sureshvv commented 5 years ago

@sh7dm Can we merge?

DRoet commented 4 years ago

Have we settled on the extra prop in the discussion above?

codecov[bot] commented 4 years ago

Codecov Report

Merging #7215 into next will decrease coverage by 0.01%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7215      +/-   ##
==========================================
- Coverage   85.79%   85.78%   -0.02%     
==========================================
  Files         329      329              
  Lines        8610     8616       +6     
  Branches     2157     2160       +3     
==========================================
+ Hits         7387     7391       +4     
- Misses       1133     1134       +1     
- Partials       90       91       +1
Impacted Files Coverage Δ
packages/vuetify/src/components/VSlider/VSlider.ts 97.19% <91.66%> (-0.54%) :arrow_down:
packages/vuetify/src/components/VSelect/VSelect.ts 93.99% <0%> (-0.43%) :arrow_down:
...ages/vuetify/src/components/VTextarea/VTextarea.ts 100% <0%> (ø) :arrow_up:
...es/vuetify/src/components/VTextField/VTextField.ts 95.41% <0%> (+0.1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a57376...1b51ee1. Read the comment docs.

sureshvv commented 4 years ago

Have we settled on the extra prop in the discussion above?

You can check out the discussion on #6814 which was the previous version of this.

johnleider commented 4 years ago

This Pull Request is being closed due to inactivity.

Thank you for your contribution and interest in improving Vuetify!

sureshvv commented 4 years ago

This is ready to be merged. Please merge. @sh7dm has our moment passed? :D

jacekkarczmarczyk commented 4 years ago

There's still no consensus on the props names

sureshvv commented 4 years ago

There's still no consensus on the props names

Let us vote and settle on one please. We have used "reverse", "decreasing", "reversed" so far.

nekosaur commented 4 years ago

My vote is for whatever we've already used before. Which I think is reverse?

sureshvv commented 4 years ago

My vote is also for "reverse".

KaelWD commented 4 years ago

I'm ok with reverse. The min/max thing sounds confusing, and left/right doesn't make sense for rtl or vertical.

jacekkarczmarczyk commented 4 years ago

The problem with reverse is that for text fields it aligns label and input texts, it could be used for placing label on the opposite side also in v-slider and selection controls (there's an issue for this afaik).

Definitely I agree that min/max and left/right are not the best, but there is still start/end option, could be also from-value/to-value or just from/to or maybe even something better

jacekkarczmarczyk commented 4 years ago

And another thing - with this playground:

<template>
  <v-app>
    <v-content>
      <v-container>
        <v-slider min="5" max="15" :tick-labels="[5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15]" />
        <v-slider min="5" max="15" :tick-labels="[5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15]" reverse />
        <v-slider min="5" max="15" :tick-labels="[5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15]" vertical />
        <v-slider min="5" max="15" :tick-labels="[5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15]" vertical reverse />
      </v-container>
    </v-content>
  </v-app>
</template>

i got this:

image

So first of all labels are wrong in reverse mode, second - I'd expect that the initial value will be the left side value (with from/to it would be less confusing), so for normal slider it'd be 5, for reverse - 15, third - keyboard navigation with up/down keys is reversed in reverse mode (up moves the slider indicator down)

sureshvv commented 4 years ago

@jacekkarczmarczyk... your playground works correctly for me now.

sureshvv commented 4 years ago

Screenshot from 2019-06-01 00-22-54

jacekkarczmarczyk commented 4 years ago

Great, ty, still there are 2 other issues in my comment

TravisBuddy commented 4 years ago

Travis tests have failed

Hey @sureshvv, Please read the following log in order to understand the failure reason. It'll be awesome if you fix what's wrong and commit the changes.

Node.js: 12

View build log

lerna run test:coverage -- -i ``` lerna notice cli v3.13.4 lerna info ci enabled lerna info Executing command in 1 package: "yarn run test:coverage -i" lerna ERR! yarn run test:coverage -i exited 1 in 'vuetify' lerna ERR! yarn run test:coverage -i stdout: yarn run v1.15.2 $ yarn test --coverage -i $ node build/run-tests.js --coverage -i $ cross-env NODE_ENV=test jest --coverage -i -----------------------------------|----------|----------|----------|----------|-------------------| File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s | -----------------------------------|----------|----------|----------|----------|-------------------| All files | 85.07 | 80.95 | 89.2 | 86.45 | | src | 0 | 0 | 0 | 0 | | entry-lib.ts | 0 | 100 | 100 | 0 | 1,2,3,4 | framework.ts | 0 | 0 | 0 | 0 |... 56,58,60,61,63 | index.ts | 0 | 0 | 0 | 0 |... 5,7,9,10,17,18 | install.ts | 0 | 0 | 0 | 0 |... 37,39,40,41,43 | src/components | 0 | 100 | 100 | 0 | | index.ts | 0 | 100 | 100 | 0 |... 71,72,73,74,75 | src/components/VAlert | 92.75 | 86 | 100 | 93.65 | | VAlert.ts | 96.97 | 86 | 100 | 98.33 | 241 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VApp | 91.67 | 75 | 100 | 91.67 | | VApp.ts | 88.89 | 75 | 100 | 88.89 | 34 | index.ts | 100 | 100 | 100 | 100 | | src/components/VAppBar | 94 | 90.48 | 100 | 95.29 | | VAppBar.ts | 98.81 | 90 | 100 | 100 |... 23,231,240,253 | VAppBarNavIcon.ts | 100 | 100 | 100 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,2,4,6 | src/components/VAutocomplete | 99.22 | 94.21 | 100 | 100 | | VAutocomplete.ts | 99.2 | 94.21 | 100 | 100 |... 76,277,293,367 | index.ts | 100 | 100 | 100 | 100 | | src/components/VAvatar | 100 | 100 | 100 | 100 | | VAvatar.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VBadge | 76.92 | 100 | 100 | 76.92 | | VBadge.ts | 100 | 100 | 100 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VBanner | 82.5 | 85.71 | 100 | 85.71 | | VBanner.ts | 89.19 | 85.71 | 100 | 93.75 | 72,74 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VBottomNav | 0 | 100 | 0 | 0 | | index.ts | 0 | 100 | 0 | 0 | 2,5,7,9,13,14 | src/components/VBottomNavigation | 82.76 | 100 | 88.89 | 82.76 | | VBottomNavigation.ts | 92.31 | 100 | 88.89 | 92.31 | 100,101 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VBottomSheet | 0 | 100 | 0 | 0 | | VBottomSheet.ts | 0 | 100 | 0 | 0 | 1,4,7,24 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VBreadcrumbs | 100 | 100 | 100 | 100 | | VBreadcrumbs.ts | 100 | 100 | 100 | 100 | | VBreadcrumbsItem.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VBtn | 100 | 95.35 | 100 | 100 | | VBtn.ts | 100 | 95.35 | 100 | 100 | 120,159 | index.ts | 100 | 100 | 100 | 100 | | src/components/VBtnToggle | 70 | 100 | 100 | 70 | | VBtnToggle.ts | 100 | 100 | 100 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VCalendar | 65.04 | 39.18 | 75 | 66.04 | | VCalendar.ts | 41.18 | 13.73 | 41.67 | 39.13 |... 99,200,202,203 | VCalendarDaily.ts | 91.07 | 68.18 | 82.76 | 91.07 |80,104,154,187,222 | VCalendarMonthly.ts | 100 | 100 | 100 | 100 | | VCalendarWeekly.ts | 90.38 | 66.67 | 80 | 90.2 | 28,66,130,146,165 | index.ts | 0 | 100 | 100 | 0 | 1,2,3,4,6,8 | src/components/VCalendar/mixins | 100 | 88.89 | 100 | 100 | | calendar-base.ts | 100 | 100 | 100 | 100 | | calendar-with-intervals.ts | 100 | 100 | 100 | 100 | | mouse.ts | 100 | 58.82 | 100 | 100 | 50,55,68 | times.ts | 100 | 100 | 100 | 100 | | src/components/VCalendar/util | 99.21 | 95.79 | 100 | 100 | | props.ts | 100 | 100 | 100 | 100 | | timestamp.ts | 99.19 | 95.79 | 100 | 100 | 50,60,308 | src/components/VCard | 74.36 | 90 | 100 | 78.79 | | VCard.ts | 100 | 90 | 100 | 100 | 84 | VCardText.ts | 100 | 100 | 100 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,2,3,5,6,8,10 | src/components/VCarousel | 85.29 | 77.78 | 75 | 85.25 | | VCarousel.ts | 90 | 77.78 | 94.12 | 89.13 | 97,98,100,101,182 | VCarouselItem.ts | 100 | 100 | 28.57 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,2,4,6 | src/components/VCheckbox | 93.18 | 68.42 | 77.78 | 94.87 | | VCheckbox.ts | 100 | 100 | 100 | 100 | | VSimpleCheckbox.ts | 88 | 53.85 | 33.33 | 90.48 | 82,83 | index.ts | 100 | 100 | 100 | 100 | | src/components/VChip | 95.74 | 86.21 | 100 | 100 | | VChip.ts | 95.45 | 86.21 | 100 | 100 | 127,165,166,175 | index.ts | 100 | 100 | 100 | 100 | | src/components/VChipGroup | 78.57 | 50 | 100 | 76.92 | | VChipGroup.ts | 100 | 50 | 100 | 100 | 44 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VColorPicker | 79.43 | 58.62 | 85.45 | 84.52 | | VColorPicker.ts | 96.15 | 100 | 90.91 | 96.15 | 112 | VColorPickerCanvas.ts | 53.7 | 25 | 53.85 | 65.91 |... 14,116,119,120 | VColorPickerEdit.ts | 95.83 | 77.27 | 100 | 95 | 88,93 | VColorPickerPreview.ts | 100 | 50 | 100 | 100 | 37,41,76 | VColorPickerSwatches.ts | 95.83 | 30 | 87.5 | 95.83 | 77 | index.ts | 0 | 100 | 100 | 0 | 1,2,3,5,6 | src/components/VColorPicker/util | 84.48 | 69.57 | 100 | 95.74 | | index.ts | 84.48 | 69.57 | 100 | 95.74 | 130,131 | src/components/VCombobox | 90.12 | 82.81 | 95.45 | 93.24 | | VCombobox.ts | 93.59 | 82.81 | 95.45 | 97.18 | 35,143 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VContent | 82.35 | 100 | 100 | 72.73 | | VContent.ts | 100 | 100 | 100 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,3,5 | src/components/VCounter | 100 | 100 | 100 | 100 | | VCounter.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VData | 83.33 | 78.57 | 79.17 | 86.02 | | VData.ts | 82.86 | 78.57 | 79.17 | 85.56 |... 83,284,285,287 | index.ts | 100 | 100 | 100 | 100 | | src/components/VDataIterator | 89.83 | 83.17 | 88.71 | 92.72 | | VDataFooter.ts | 97.96 | 91.89 | 100 | 100 | 67,142,146 | VDataIterator.ts | 86.18 | 78.13 | 84.09 | 89.22 |... 75,276,277,278 | index.ts | 100 | 100 | 100 | 100 | | src/components/VDataTable | 86.82 | 82.95 | 83.46 | 89.6 | | VDataTable.ts | 85.11 | 71.11 | 76.06 | 86.79 |... 27,528,529,530 | VDataTableHeader.ts | 100 | 100 | 100 | 100 | | VDataTableHeaderDesktop.ts | 92.5 | 92.86 | 71.43 | 97.3 | 14 | VDataTableHeaderMobile.ts | 93.33 | 100 | 88.89 | 92.86 | 33,34 | VEditDialog.ts | 100 | 91.67 | 100 | 100 | 133 | VMobileRow.ts | 100 | 100 | 100 | 100 | | VRow.ts | 95.24 | 83.33 | 100 | 94.74 | 38 | VRowGroup.ts | 100 | 100 | 100 | 100 | | VSimpleTable.ts | 100 | 100 | 100 | 100 | | VVirtualTable.ts | 93.55 | 100 | 94.74 | 93.55 | 86,87 | index.ts | 0 | 100 | 100 | 0 |... ,9,10,12,14,16 | src/components/VDataTable/mixins | 100 | 100 | 100 | 100 | | header.ts | 100 | 100 | 100 | 100 | | src/components/VDatePicker | 89.63 | 81.2 | 94.9 | 89.82 | | VDatePicker.ts | 91.67 | 77.16 | 94.44 | 92.65 |... 16,225,226,268 | VDatePickerDateTable.ts | 95.74 | 88.89 | 92.86 | 95.56 | 41,65 | VDatePickerHeader.ts | 100 | 90.91 | 100 | 100 | 75 | VDatePickerMonthTable.ts | 100 | 100 | 100 | 100 | | VDatePickerTitle.ts | 100 | 100 | 100 | 100 | | VDatePickerYears.ts | 86.21 | 84.62 | 87.5 | 85.71 | 56,57,58,60 | index.ts | 0 | 100 | 100 | 0 |... 11,12,13,14,17 | src/components/VDatePicker/mixins | 95.45 | 89.29 | 100 | 95.24 | | date-picker-table.ts | 95.45 | 89.29 | 100 | 95.24 | 135,143,149 | src/components/VDatePicker/util | 100 | 93.33 | 100 | 100 | | createNativeLocaleFormatter.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | isDateAllowed.ts | 100 | 66.67 | 100 | 100 | 4 | monthChange.ts | 100 | 100 | 100 | 100 | | pad.ts | 100 | 100 | 100 | 100 | | src/components/VDialog | 67.39 | 56.67 | 66.67 | 70.93 | | VDialog.ts | 69.66 | 56.67 | 66.67 | 73.49 |... 20,221,234,243 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VDivider | 100 | 100 | 100 | 100 | | VDivider.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VExpansionPanel | 86.84 | 93.75 | 96.88 | 90 | | VExpansionPanel.ts | 100 | 100 | 100 | 100 | | VExpansionPanelContent.ts | 100 | 100 | 100 | 100 | | VExpansionPanelHeader.ts | 95.45 | 83.33 | 91.67 | 95.45 | 63 | VExpansionPanels.ts | 100 | 100 | 100 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,2,3,4,6,8 | src/components/VFooter | 89.29 | 96.67 | 100 | 88 | | VFooter.ts | 100 | 96.67 | 100 | 100 | 57 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VForm | 88.89 | 75 | 91.67 | 90.91 | | VForm.ts | 94.12 | 75 | 91.67 | 97.56 | 131 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VGrid | 76.74 | 93.75 | 100 | 74.36 | | VContainer.ts | 100 | 100 | 100 | 100 | | VFlex.ts | 100 | 100 | 100 | 100 | | VLayout.ts | 100 | 100 | 100 | 100 | | grid.ts | 100 | 93.75 | 100 | 100 | 23 | index.ts | 0 | 100 | 100 | 0 |... 11,12,13,14,17 | src/components/VHover | 87.5 | 94.44 | 100 | 87.5 | | VHover.ts | 100 | 94.44 | 100 | 100 | 64 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VIcon | 100 | 97.14 | 100 | 100 | | VIcon.ts | 100 | 97.14 | 100 | 100 | 207 | index.ts | 100 | 100 | 100 | 100 | | src/components/VImg | 96.05 | 90.91 | 100 | 100 | | VImg.ts | 95.89 | 90.91 | 100 | 100 | 80,97,169,170,207 | index.ts | 100 | 100 | 100 | 100 | | src/components/VInput | 97.14 | 100 | 96.3 | 97.01 | | VInput.ts | 97.01 | 100 | 96.3 | 96.88 | 170,171 | index.ts | 100 | 100 | 100 | 100 | | src/components/VItemGroup | 90.6 | 96.39 | 90.91 | 90.2 | | VItem.ts | 95 | 92.86 | 66.67 | 95 | 27 | VItemGroup.ts | 94.57 | 97.1 | 93.33 | 94.81 | 56,57,59,60 | index.ts | 0 | 100 | 100 | 0 | 1,2,5,6,9 | src/components/VLabel | 100 | 100 | 100 | 100 | | VLabel.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VList | 82.81 | 84.15 | 69.39 | 85.38 | | VList.ts | 40 | 0 | 50 | 57.14 | 63,66,68,71,73,74 | VListGroup.ts | 98.15 | 86.67 | 100 | 100 |... 26,174,176,184 | VListItem.ts | 100 | 100 | 100 | 100 | | VListItemAction.ts | 90 | 87.5 | 100 | 100 | 15 | VListItemAvatar.ts | 100 | 75 | 100 | 100 | 32 | VListItemGroup.ts | 62.5 | 100 | 0 | 62.5 | 20,27,36 | VListItemIcon.ts | 100 | 50 | 100 | 100 | 11 | index.ts | 69.81 | 100 | 0 | 69.81 |... 51,53,58,60,62 | src/components/VMenu | 72.26 | 64.71 | 71.05 | 74.02 | | VMenu.ts | 71.64 | 64.71 | 71.05 | 73.39 |... 42,349,350,351 | index.ts | 100 | 100 | 100 | 100 | | src/components/VMessages | 100 | 100 | 100 | 100 | | VMessages.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VNavigationDrawer | 86.81 | 90.67 | 93.18 | 87.7 | | VNavigationDrawer.ts | 88.65 | 90.67 | 93.18 | 89.92 |... 40,341,342,362 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VOverflowBtn | 76.92 | 61.54 | 100 | 77.78 | | VOverflowBtn.ts | 83.33 | 61.54 | 100 | 84.85 | 72,75,77,84,85 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VOverlay | 100 | 100 | 100 | 100 | | VOverlay.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VPagination | 95.08 | 100 | 100 | 94.92 | | VPagination.ts | 100 | 100 | 100 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VParallax | 66.67 | 66.67 | 71.43 | 69.23 | | VParallax.ts | 75 | 66.67 | 71.43 | 78.26 | 61,62,65,66,73 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VPicker | 100 | 91.67 | 100 | 100 | | VPicker.ts | 100 | 91.67 | 100 | 100 | 59 | index.ts | 100 | 100 | 100 | 100 | | src/components/VProgressCircular | 100 | 100 | 100 | 100 | | VProgressCircular.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VProgressLinear | 98.21 | 92.11 | 100 | 100 | | VProgressLinear.ts | 98.11 | 92.11 | 100 | 100 | 200,224,226 | index.ts | 100 | 100 | 100 | 100 | | src/components/VRadioGroup | 88.14 | 95.35 | 100 | 91.07 | | VRadio.ts | 95 | 95.12 | 100 | 97.37 | 163 | VRadioGroup.ts | 100 | 100 | 100 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,2,4,6 | src/components/VRangeSlider | 80.56 | 75.86 | 88.46 | 83.7 | | VRangeSlider.ts | 82.86 | 75.86 | 88.46 | 86.52 |... 93,195,196,199 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VRating | 96.25 | 98.15 | 100 | 95.71 | | VRating.ts | 100 | 98.15 | 100 | 100 | 164 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VResponsive | 100 | 100 | 100 | 100 | | VResponsive.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VSelect | 91.77 | 86.44 | 91.84 | 92.76 | | VSelect.ts | 92.8 | 89.44 | 93.15 | 94.39 |... 08,611,616,617 | VSelectList.ts | 92.13 | 76.79 | 88 | 91.78 |... 84,185,187,204 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VSheet | 100 | 100 | 100 | 100 | | VSheet.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VSlideGroup | 74.04 | 90.38 | 81.82 | 75 | | VSlideGroup.ts | 81.05 | 90.38 | 81.82 | 82.76 |... 57,260,261,306 | VSlideItem.ts | 0 | 100 | 100 | 0 | 2,5,6,8 | index.ts | 0 | 100 | 100 | 0 | 1,2,5,6,9 | src/components/VSlider | 97.38 | 86.98 | 100 | 99.41 | | VSlider.ts | 97.34 | 86.98 | 100 | 99.4 | 482 | index.ts | 100 | 100 | 100 | 100 | | src/components/VSnackbar | 84.21 | 90 | 100 | 84.21 | | VSnackbar.ts | 100 | 90 | 100 | 100 | 44 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VSparkline | 79.44 | 61.11 | 96.67 | 79.17 | | VSparkline.ts | 81.73 | 61.11 | 96.67 | 81.72 |... 18,219,220,222 | index.ts | 0 | 100 | 100 | 0 | 1,3,5 | src/components/VSparkline/helpers | 95.83 | 76.92 | 100 | 100 | | core.ts | 100 | 83.33 | 100 | 100 | 16 | math.ts | 100 | 100 | 100 | 100 | | path.ts | 90 | 72.22 | 100 | 100 | 7,12,28,36 | src/components/VSpeedDial | 87.5 | 100 | 87.5 | 86.67 | | VSpeedDial.ts | 96.55 | 100 | 87.5 | 96.3 | 59 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VStepper | 52.27 | 56.67 | 57.14 | 52.89 | | VStepper.ts | 0 | 0 | 0 | 0 |... 16,118,119,125 | VStepperContent.ts | 100 | 100 | 100 | 100 | | VStepperStep.ts | 67.65 | 47.06 | 71.43 | 69.7 |... 24,129,135,136 | index.ts | 0 | 100 | 100 | 0 |... 11,12,13,14,17 | src/components/VSubheader | 100 | 100 | 100 | 100 | | VSubheader.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/components/VSwitch | 87.5 | 86.36 | 100 | 86.36 | | VSwitch.ts | 100 | 86.36 | 100 | 100 | 103,104 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VSystemBar | 83.33 | 90.91 | 100 | 83.33 | | VSystemBar.ts | 100 | 90.91 | 100 | 100 | 39 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VTabs | 85.89 | 79.01 | 93.55 | 89.71 | | VTab.ts | 96.77 | 94.12 | 100 | 100 | 83 | VTabItem.ts | 100 | 100 | 100 | 100 | | VTabs.ts | 87.34 | 70.83 | 88.24 | 91.18 |... 01,225,265,266 | VTabsBar.ts | 97.06 | 87.5 | 100 | 96.15 | 54 | VTabsItems.ts | 100 | 100 | 100 | 100 | | VTabsSlider.ts | 100 | 100 | 100 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,2,3,4,5,7,9 | src/components/VTextField | 95 | 86.47 | 100 | 95.2 | | VTextField.ts | 94.89 | 86.47 | 100 | 95.08 |... 38,249,446,456 | index.ts | 100 | 100 | 100 | 100 | | src/components/VTextarea | 87.88 | 92.86 | 100 | 90.63 | | VTextarea.ts | 96.67 | 92.86 | 100 | 100 | 73 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VTimePicker | 94.34 | 87.69 | 95.71 | 96.51 | | VTimePicker.ts | 95.36 | 85.71 | 92.68 | 97.62 | 284,293,294 | VTimePickerClock.ts | 98.82 | 91.07 | 100 | 100 | 114,183,189,193 | VTimePickerTitle.ts | 100 | 95.45 | 100 | 100 | 39 | index.ts | 0 | 100 | 100 | 0 | 1,2,3,5,7 | src/components/VTimeline | 85.71 | 85.71 | 100 | 87.5 | | VTimeline.ts | 100 | 100 | 100 | 100 | | VTimelineItem.ts | 100 | 85.71 | 100 | 100 | 115,116 | index.ts | 0 | 100 | 100 | 0 | 1,2,4,6 | src/components/VToolbar | 39.39 | 45.31 | 84.62 | 36.36 | | VToolbar.ts | 95.12 | 85.29 | 100 | 100 | 56,57,61,62,102 | VToolbarSideIcon.ts | 0 | 100 | 0 | 0 | 2,5,11,15,17 | index.ts | 0 | 0 | 0 | 0 |... 15,116,117,120 | src/components/VTooltip | 70.67 | 50.85 | 72.22 | 74.24 | | VTooltip.ts | 73.61 | 50.85 | 72.22 | 77.78 |... 74,177,178,179 | index.ts | 0 | 100 | 100 | 0 | 1,3,4 | src/components/VTreeview | 93.75 | 87.5 | 97.4 | 96.65 | | VTreeview.ts | 95.02 | 87.06 | 95.83 | 98.17 | 212,213,351 | VTreeviewNode.ts | 96.34 | 88.37 | 100 | 98.59 | 239 | index.ts | 0 | 100 | 100 | 0 | 1,2,4,6 | src/components/VTreeview/util | 100 | 100 | 100 | 100 | | filterTreeItems.ts | 100 | 100 | 100 | 100 | | src/components/VWindow | 95.9 | 94.2 | 100 | 96.49 | | VWindow.ts | 100 | 91.3 | 100 | 100 | 165,179,252,255 | VWindowItem.ts | 100 | 100 | 100 | 100 | | index.ts | 0 | 100 | 100 | 0 | 1,2,4,6 | src/components/transitions | 52.46 | 37.5 | 12.5 | 50.91 | | expand-transition.ts | 23.68 | 37.5 | 12.5 | 15.63 |... 78,82,83,84,85 | index.ts | 100 | 100 | 100 | 100 | | src/directives | 0 | 100 | 100 | 0 | | index.ts | 0 | 100 | 100 | 0 | 1,2,3,4,5 | src/directives/click-outside | 95.83 | 96.55 | 100 | 100 | | index.ts | 95.83 | 96.55 | 100 | 100 | 73 | src/directives/resize | 93.75 | 87.5 | 100 | 100 | | index.ts | 93.75 | 87.5 | 100 | 100 | 24 | src/directives/ripple | 77.4 | 62.5 | 78.95 | 78.79 | | index.ts | 77.4 | 62.5 | 78.95 | 78.79 |... 07,208,209,210 | src/directives/scroll | 94.44 | 87.5 | 100 | 100 | | index.ts | 94.44 | 87.5 | 100 | 100 | 14 | src/directives/touch | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/locale | 100 | 100 | 100 | 100 | | af.ts | 100 | 100 | 100 | 100 | | ar.ts | 100 | 100 | 100 | 100 | | ca.ts | 100 | 100 | 100 | 100 | | de.ts | 100 | 100 | 100 | 100 | | el.ts | 100 | 100 | 100 | 100 | | en.ts | 100 | 100 | 100 | 100 | | es.ts | 100 | 100 | 100 | 100 | | et.ts | 100 | 100 | 100 | 100 | | fa.ts | 100 | 100 | 100 | 100 | | fr.ts | 100 | 100 | 100 | 100 | | he.ts | 100 | 100 | 100 | 100 | | hr.ts | 100 | 100 | 100 | 100 | | hu.ts | 100 | 100 | 100 | 100 | | id.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | it.ts | 100 | 100 | 100 | 100 | | ja.ts | 100 | 100 | 100 | 100 | | lv.ts | 100 | 100 | 100 | 100 | | nl.ts | 100 | 100 | 100 | 100 | | pl.ts | 100 | 100 | 100 | 100 | | pt.ts | 100 | 100 | 100 | 100 | | ro.ts | 100 | 100 | 100 | 100 | | ru.ts | 100 | 100 | 100 | 100 | | sl.ts | 100 | 100 | 100 | 100 | | sr-Cyrl.ts | 100 | 100 | 100 | 100 | | th.ts | 100 | 100 | 100 | 100 | | tr.ts | 100 | 100 | 100 | 100 | | uk.ts | 100 | 100 | 100 | 100 | | zh-Hans.ts | 100 | 100 | 100 | 100 | | zh-Hant.ts | 100 | 100 | 100 | 100 | | src/mixins/activatable | 100 | 88.46 | 100 | 100 | | index.ts | 100 | 88.46 | 100 | 100 | 97,112,118 | src/mixins/applicationable | 88.89 | 91.67 | 83.33 | 90 | | index.ts | 88.89 | 91.67 | 83.33 | 90 | 36,51 | src/mixins/bootable | 88.89 | 85.71 | 100 | 88.89 | | index.ts | 88.89 | 85.71 | 100 | 88.89 | 45 | src/mixins/button-group | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/colorable | 100 | 83.33 | 100 | 100 | | index.ts | 100 | 83.33 | 100 | 100 | 18,24,47,53 | src/mixins/comparable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/delayable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/dependent | 96.97 | 91.67 | 100 | 100 | | index.ts | 96.97 | 91.67 | 100 | 100 | 74 | src/mixins/detachable | 82.98 | 73.33 | 83.33 | 84.09 | | index.ts | 82.98 | 73.33 | 83.33 | 84.09 |... ,98,99,100,105 | src/mixins/elevatable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/filterable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/groupable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/loadable | 100 | 80 | 100 | 100 | | index.ts | 100 | 80 | 100 | 100 | 39,40 | src/mixins/localable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/measurable | 86.96 | 75 | 100 | 100 | | index.ts | 86.96 | 75 | 100 | 100 | 34,35,38 | src/mixins/menuable | 88.65 | 75.44 | 93.75 | 93.6 | | index.ts | 88.65 | 75.44 | 93.75 | 93.6 |... 56,257,329,330 | src/mixins/overlayable | 32.35 | 17.86 | 43.75 | 34.09 | | index.ts | 32.35 | 17.86 | 43.75 | 34.09 |... 94,197,199,203 | src/mixins/picker | 87.5 | 100 | 50 | 87.5 | | index.ts | 87.5 | 100 | 50 | 87.5 | 34,37 | src/mixins/picker-button | 92.31 | 90 | 100 | 100 | | index.ts | 92.31 | 90 | 100 | 100 | 19 | src/mixins/positionable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/proxyable | 93.75 | 83.33 | 100 | 100 | | index.ts | 93.75 | 83.33 | 100 | 100 | 40 | src/mixins/registrable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/returnable | 60 | 100 | 50 | 60 | | index.ts | 60 | 100 | 50 | 60 | 27,28,29,30 | src/mixins/rippleable | 100 | 100 | 50 | 100 | | index.ts | 100 | 100 | 50 | 100 | | src/mixins/routable | 95.65 | 92.59 | 81.82 | 97.44 | | index.ts | 95.65 | 92.59 | 81.82 | 97.44 | 82 | src/mixins/scrollable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/selectable | 91.84 | 91.43 | 85.71 | 95.45 | | index.ts | 91.84 | 91.43 | 85.71 | 95.45 | 116,126 | src/mixins/sizeable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/ssr-bootable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/stackable | 90.48 | 78.57 | 100 | 100 | | index.ts | 90.48 | 78.57 | 100 | 100 | 25,34,57 | src/mixins/themeable | 91.3 | 75 | 100 | 91.3 | | index.ts | 91.3 | 75 | 100 | 91.3 | 80,83 | src/mixins/toggleable | 100 | 83.33 | 100 | 100 | | index.ts | 100 | 83.33 | 100 | 100 | 7 | src/mixins/transitionable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/mixins/translatable | 16.67 | 100 | 14.29 | 16.67 | | index.ts | 16.67 | 100 | 14.29 | 16.67 |... 43,47,50,52,57 | src/mixins/validatable | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/services | 0 | 100 | 100 | 0 | | index.ts | 0 | 100 | 100 | 0 | 1,2,3,4,5,6 | src/services/application | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/services/breakpoint | 100 | 96.83 | 100 | 100 | | index.ts | 100 | 96.83 | 100 | 100 | 138,147 | src/services/goto | 100 | 93.48 | 95.24 | 100 | | easing-patterns.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 83.33 | 75 | 100 | 21,38,47 | util.ts | 100 | 100 | 100 | 100 | | src/services/icons | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | src/services/icons/presets | 100 | 100 | 100 | 100 | | fa.ts | 100 | 100 | 100 | 100 | | fa4.ts | 100 | 100 | 100 | 100 | | index.ts | 100 | 100 | 100 | 100 | | md.ts | 100 | 100 | 100 | 100 | | mdi-svg.ts | 100 | 100 | 100 | 100 | | mdi.ts | 100 | 100 | 100 | 100 | | src/services/lang | 100 | 100 | 80 | 100 | | index.ts | 100 | 100 | 80 | 100 | | src/services/service | 100 | 100 | 50 | 100 | | index.ts | 100 | 100 | 50 | 100 | | src/services/theme | 98.31 | 92.31 | 100 | 100 | | index.ts | 97 | 86.96 | 100 | 100 |... 92,194,201,205 | utils.ts | 100 | 100 | 100 | 100 | | src/util | 74.01 | 66.96 | 74.07 | 77.21 | | ThemeProvider.ts | 100 | 83.33 | 100 | 100 | 15 | colorUtils.ts | 92.11 | 91.3 | 86.36 | 94.79 |... 90,200,201,203 | colors.ts | 100 | 100 | 100 | 100 | | component.ts | 0 | 100 | 0 | 0 | 19,20 | console.ts | 75.93 | 64.29 | 66.67 | 75 |... 86,87,88,90,91 | dedupeModelListeners.ts | 28.57 | 22.22 | 100 | 33.33 | 11,12,13,15 | easing-patterns.js | 0 | 100 | 100 | 0 | 1,3,5 | helpers.ts | 87.79 | 76.92 | 81.03 | 92.93 |... 60,466,467,475 | mixins.ts | 100 | 100 | 100 | 100 | | rebuildFunctionalSlots.ts | 66.67 | 0 | 100 | 66.67 | 7,8 | theme.ts | 0 | 0 | 0 | 0 |... 23,127,128,129 | src/util/color | 100 | 100 | 100 | 100 | | transformCIELAB.ts | 100 | 100 | 100 | 100 | | transformSRGB.ts | 100 | 100 | 100 | 100 | | -----------------------------------|----------|----------|----------|----------|-------------------| info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command. lerna ERR! yarn run test:coverage -i stderr: PASS Vuetify src/components/VTimePicker/__tests__/VTimePicker.spec.ts (9.023s) PASS Vuetify src/components/VCalendar/util/__tests__/timestamp.spec.ts PASS Vuetify src/components/VTextField/__tests__/VTextField.spec.ts PASS Vuetify src/components/VDatePicker/__tests__/VDatePicker.date.spec.ts PASS Vuetify src/components/VTreeview/__tests__/VTreeview.spec.ts FAIL Vuetify src/components/VSlider/__tests__/VSlider.spec.ts ● VSlider.ts › should be decreasing when reverse is set expect(received).toMatchSnapshot() Snapshot name: `VSlider.ts should be decreasing when reverse is set 1` - Snapshot + Received @@ -1,32 +1,32 @@ -
+
-
609 | }) 610 | > 611 | expect(wrapper.html()).toMatchSnapshot() | ^ 612 | 613 | wrapper.vm.$vuetify.rtl = true 614 | at Object. (src/components/VSlider/__tests__/VSlider.spec.ts:611:28) at step (src/components/VSlider/__tests__/VSlider.spec.ts:138:17) at Object.next (src/components/VSlider/__tests__/VSlider.spec.ts:69:14) at src/components/VSlider/__tests__/VSlider.spec.ts:41:67 at Object..__awaiter (src/components/VSlider/__tests__/VSlider.spec.ts:18:10) at Object. (src/components/VSlider/__tests__/VSlider.spec.ts:606:50) ● VSlider.ts › should be decreasing when reverse is set expect(received).toMatchSnapshot() Snapshot name: `VSlider.ts should be decreasing when reverse is set 2` - Snapshot + Received @@ -1,32 +1,32 @@ -
+
-
613 | wrapper.vm.$vuetify.rtl = true 614 | > 615 | expect(wrapper.html()).toMatchSnapshot() | ^ 616 | }) 617 | }) 618 | at Object. (src/components/VSlider/__tests__/VSlider.spec.ts:615:28) at step (src/components/VSlider/__tests__/VSlider.spec.ts:138:17) at Object.next (src/components/VSlider/__tests__/VSlider.spec.ts:69:14) at src/components/VSlider/__tests__/VSlider.spec.ts:41:67 at Object..__awaiter (src/components/VSlider/__tests__/VSlider.spec.ts:18:10) at Object. (src/components/VSlider/__tests__/VSlider.spec.ts:606:50) › 2 snapshots failed. › 1 snapshot obsolete. • VSlider.ts should correctly handle setting value to zero (#7320) 1 PASS Vuetify src/components/VAutocomplete/__tests__/VAutocomplete.spec.ts (6.696s) PASS Vuetify src/components/VCombobox/__tests__/VCombobox-multiple.spec.ts PASS Vuetify src/components/VNavigationDrawer/__tests__/VNavigationDrawer.spec.ts (8.207s) PASS Vuetify src/components/VCalendar/mixins/__tests__/calendar-with-intervals.spec.ts PASS Vuetify src/components/VSelect/__tests__/VSelect.spec.ts PASS Vuetify src/components/VAutocomplete/__tests__/VAutocomplete2.spec.ts PASS Vuetify src/components/VSelect/__tests__/VSelect3.spec.ts PASS Vuetify src/components/VSelect/__tests__/VSelect2.spec.ts PASS Vuetify src/mixins/validatable/__tests__/validatable.spec.ts PASS Vuetify src/components/VCheckbox/__tests__/VCheckbox.spec.ts PASS Vuetify src/components/VIcon/__tests__/VIcon.spec.ts PASS Vuetify src/util/__tests__/helpers.spec.ts PASS Vuetify src/components/VData/__tests__/VData.spec.ts PASS Vuetify src/components/VItemGroup/__tests__/VItemGroup.spec.ts PASS Vuetify src/components/VDialog/__tests__/VDialog.spec.ts PASS Vuetify src/components/VSlideGroup/__tests__/VSlideGroup.spec.ts PASS Vuetify src/components/VWindow/__tests__/VWindow.spec.ts PASS Vuetify src/components/VDatePicker/__tests__/VDatePickerDateTable.spec.ts PASS Vuetify src/components/VDataTable/__tests__/VDataTable.spec.ts PASS Vuetify src/components/VDataIterator/__tests__/VDataIterator.spec.ts PASS Vuetify src/components/VDatePicker/__tests__/VDatePicker.month.spec.ts PASS Vuetify src/components/VCombobox/__tests__/VCombobox.spec.ts PASS Vuetify src/components/VStepper/__tests__/VStepperContent.spec.ts PASS Vuetify src/components/VTimePicker/__tests__/VTimePickerClock.spec.ts PASS Vuetify src/components/VAppBar/__tests__/VAppBar.spec.ts PASS Vuetify src/components/VBtn/__tests__/VBtn.spec.ts PASS Vuetify src/components/VDatePicker/__tests__/VDatePickerMonthTable.spec.ts PASS Vuetify src/services/theme/__tests__/theme.spec.ts PASS Vuetify src/components/VInput/__tests__/VInput.spec.ts PASS Vuetify src/components/VPagination/__tests__/VPagination.spec.ts PASS Vuetify src/components/VDatePicker/__tests__/VDatePickerHeader.spec.ts PASS Vuetify src/components/VProgressLinear/__tests__/VProgressLinear.spec.ts PASS Vuetify src/services/breakpoint/__tests__/breakpoint.spec.ts PASS Vuetify src/components/VTimePicker/__tests__/VTimePickerTitle.spec.ts PASS Vuetify src/components/VMenu/__tests__/VMenu.spec.ts PASS Vuetify src/components/VCalendar/mixins/__tests__/calendar-base.spec.ts PASS Vuetify src/components/VForm/__tests__/VForm.spec.ts PASS Vuetify src/components/VRating/__tests__/VRating.spec.ts PASS Vuetify src/components/VRangeSlider/__tests__/VRangeSlider.spec.ts PASS Vuetify src/components/VCalendar/__tests__/VCalendarDailly.spec.ts PASS Vuetify src/components/VSparkline/__tests__/VSparkline.spec.ts PASS Vuetify src/util/__tests__/colorUtils.spec.ts PASS Vuetify src/components/VSelect/__tests__/VSelect4.spec.ts PASS Vuetify src/components/VDataTable/__tests__/VEditDialog.spec.ts PASS Vuetify src/components/VDataIterator/__tests__/VDataFooter.spec.ts PASS Vuetify src/components/VImg/__tests__/VImg.spec.ts PASS Vuetify src/components/VBanner/__tests__/VBanner.spec.ts PASS Vuetify src/components/VWindow/__tests__/VWindowItem.spec.ts PASS Vuetify src/components/VList/__tests__/VListGroup.spec.ts PASS Vuetify src/components/VDataTable/__tests__/VDataTableHeader.spec.ts PASS Vuetify src/components/VAlert/__tests__/VAlert.spec.ts PASS Vuetify src/components/VRadioGroup/__tests__/VRadio.spec.ts PASS Vuetify src/components/VList/__tests__/VListItem.spec.ts PASS Vuetify src/components/VExpansionPanel/__tests__/VExpansionPanel.spec.ts PASS Vuetify src/components/VTabs/__tests__/VTabs.spec.ts PASS Vuetify src/components/VTextarea/__tests__/VTextarea.spec.ts PASS Vuetify src/mixins/applicationable/__tests__/applicationable.spec.ts PASS Vuetify src/components/VColorPicker/__tests__/VColorPickerEdit.spec.ts PASS Vuetify src/components/VProgressCircular/__tests__/VProgressCircular.spec.ts PASS Vuetify src/components/VTooltip/__tests__/VTooltip.spec.ts PASS Vuetify src/components/VDatePicker/__tests__/VDatePickerTitle.spec.ts PASS Vuetify src/components/VSwitch/__tests__/VSwitch.spec.ts PASS Vuetify src/directives/click-outside/__tests__/click-outside.spec.ts PASS Vuetify src/components/VChip/__tests__/VChip.spec.ts PASS Vuetify src/components/VSelect/__tests__/VSelectList.spec.ts PASS Vuetify src/components/VColorPicker/__tests__/VColorPicker.spec.ts PASS Vuetify src/components/VCarousel/__tests__/VCarousel.spec.ts PASS Vuetify src/components/VBadge/__tests__/VBadge.spec.ts PASS Vuetify src/mixins/detachable/__tests__/detachable.spec.ts PASS Vuetify src/mixins/activatable/__tests__/activatable.spec.ts PASS Vuetify src/components/VTabs/__tests__/VTab.spec.ts PASS Vuetify src/components/VCalendar/mixins/__tests__/mouse.spec.ts PASS Vuetify src/directives/touch/__tests__/touch.spec.ts PASS Vuetify src/components/VSnackbar/__tests__/VSnackbar.spec.ts PASS Vuetify src/components/VDataTable/__tests__/VSimpleTable.spec.ts PASS Vuetify src/components/VDataTable/mixins/__tests__/header.spec.ts PASS Vuetify src/mixins/scrollable/__tests__/scrollable.spec.ts PASS Vuetify src/components/VHover/__tests__/VHover.spec.ts PASS Vuetify src/services/goto/__tests__/goto.spec.ts PASS Vuetify src/components/VDataTable/__tests__/VMobileRow.spec.ts PASS Vuetify src/components/VDataTable/__tests__/VRow.spec.ts PASS Vuetify src/components/VCalendar/__tests__/VCalendar.spec.ts PASS Vuetify src/components/VOverflowBtn/__tests__/VOverflowBtn.spec.ts PASS Vuetify src/components/VBottomNavigation/__tests__/VBottomNavigation.spec.ts PASS Vuetify src/mixins/dependent/__tests__/dependent.spec.ts PASS Vuetify src/components/VTreeview/__tests__/VTreeviewNode.spec.ts PASS Vuetify src/components/VBreadcrumbs/__tests__/VBreadcrumbs.spec.ts PASS Vuetify src/components/VDatePicker/__tests__/VDatePickerYears.spec.ts PASS Vuetify src/mixins/colorable/__tests__/colorable.spec.ts PASS Vuetify src/components/VList/__tests__/VListItemAction.spec.ts PASS Vuetify src/components/VCalendar/mixins/__tests__/times.spec.ts PASS Vuetify src/components/VToolbar/__tests__/VToolbar.spec.ts PASS Vuetify src/components/VSpeedDial/__tests__/VSpeedDial.spec.ts PASS Vuetify src/mixins/bootable/__tests__/bootable.spec.ts PASS Vuetify src/components/VCard/__tests__/VCard.spec.ts PASS Vuetify src/directives/scroll/__tests__/scroll.spec.ts PASS Vuetify src/components/VPicker/__tests__/VPicker.spec.ts PASS Vuetify src/components/VColorPicker/util/__tests__/index.spec.ts PASS Vuetify src/components/VItemGroup/__tests__/VItem.spec.ts PASS Vuetify src/components/VGrid/__tests__/VGrid.spec.ts PASS Vuetify src/components/VTimeline/__tests__/VTimelineItem.spec.ts PASS Vuetify src/components/VFooter/__tests__/VFooter.spec.ts PASS Vuetify src/mixins/proxyable/__tests__/proxyable.spec.ts PASS Vuetify src/components/VChipGroup/__tests__/VChipGroup.spec.ts PASS Vuetify src/mixins/menuable/__tests__/menuable.spec.ts PASS Vuetify src/components/VDataTable/__tests__/VVirtualTable.spec.ts PASS Vuetify src/directives/ripple/__tests__/ripple.spec.ts PASS Vuetify src/components/VList/__tests__/VList.spec.ts PASS Vuetify src/components/VTreeview/util/__tests__/filterTreeItems.spec.ts PASS Vuetify src/components/VDivider/__tests__/VDivider.spec.ts PASS Vuetify src/components/VApp/__tests__/VApp.spec.ts PASS Vuetify src/components/VTabs/__tests__/VTabsBar.spec.ts PASS Vuetify src/components/VSubheader/__tests__/VSubheader.spec.ts PASS Vuetify src/services/lang/__tests__/lang.spec.ts PASS Vuetify src/components/VStepper/__tests__/VStepperStep.spec.ts PASS Vuetify src/components/VSystemBar/__tests__/VSystemBar.spec.ts PASS Vuetify src/directives/resize/__tests__/resize.spec.ts PASS Vuetify src/components/VCounter/__tests__/VCounter.spec.ts PASS Vuetify src/components/VParallax/__tests__/VParallax.spec.ts PASS Vuetify src/services/goto/__tests__/easing-patterns.spec.ts PASS Vuetify src/components/VMessages/__tests__/VMessages.spec.ts PASS Vuetify src/components/VDatePicker/util/__tests__/createNativeLocaleFormatter.spec.ts PASS Vuetify src/components/VCarousel/__tests__/VCarouselItem.spec.ts PASS Vuetify src/components/VExpansionPanel/__tests__/VExpansionPanelHeader.spec.ts PASS Vuetify src/components/VResponsive/__tests__/VResponsive.spec.ts PASS Vuetify src/components/VSheet/__tests__/VSheet.spec.ts PASS Vuetify src/services/theme/__tests__/theme-utils.spec.ts PASS Vuetify src/components/VExpansionPanel/__tests__/VExpansionPanels.spec.ts PASS Vuetify src/components/VLabel/__tests__/VLabel.spec.ts PASS Vuetify src/components/VAvatar/__tests__/VAvatar.spec.ts PASS Vuetify src/components/VOverlay/__tests__/VOverlay.spec.ts PASS Vuetify src/mixins/rippleable/__tests__/rippleable.spec.ts PASS Vuetify src/components/VDataTable/__tests__/VRowGroup.spec.ts PASS Vuetify src/components/VContent/__tests__/VContent.spec.ts PASS Vuetify src/components/VCard/__tests__/VCardText.spec.ts PASS Vuetify src/mixins/elevatable/__tests__/elevatable.spec.ts PASS Vuetify src/components/VTabs/__tests__/VTabsSlider.spec.ts PASS Vuetify src/components/VAppBar/__tests__/VAppBarNavIcon.spec.ts PASS Vuetify src/components/VList/__tests__/VListItemAvatar.spec.ts PASS Vuetify src/util/__tests__/console.spec.ts PASS Vuetify src/services/application/__tests__/application.spec.ts PASS Vuetify src/components/VBreadcrumbs/__tests__/VBreadcrumbsItem.spec.ts PASS Vuetify src/components/VBtnToggle/__tests__/VBtnToggle.spec.ts PASS Vuetify src/components/VGrid/__tests__/VContainer.spec.ts PASS Vuetify src/components/VRadioGroup/__tests__/VRadioGroup.spec.ts PASS Vuetify src/services/icons/__tests__/icons.spec.ts PASS Vuetify src/components/VGrid/__tests__/VLayout.spec.ts PASS Vuetify src/components/VGrid/__tests__/VFlex.spec.ts PASS Vuetify src/locale/__tests__/index.spec.ts PASS Vuetify src/components/VCalendar/util/__tests__/props.spec.ts PASS Vuetify src/components/VDatePicker/util/__tests__/pad.spec.ts PASS Vuetify src/mixins/routable/__tests__/routable.spec.ts PASS Vuetify src/components/VDatePicker/util/__tests__/monthChange.spec.ts PASS Vuetify src/components/VTimeline/__tests__/VTimeline.spec.ts PASS Vuetify src/mixins/groupable/__tests__/groupable.spec.ts Summary of all failing tests FAIL src/components/VSlider/__tests__/VSlider.spec.ts ● VSlider.ts › should be decreasing when reverse is set expect(received).toMatchSnapshot() Snapshot name: `VSlider.ts should be decreasing when reverse is set 1` - Snapshot + Received @@ -1,32 +1,32 @@ -
+
-
609 | }) 610 | > 611 | expect(wrapper.html()).toMatchSnapshot() | ^ 612 | 613 | wrapper.vm.$vuetify.rtl = true 614 | at Object. (src/components/VSlider/__tests__/VSlider.spec.ts:611:28) at step (src/components/VSlider/__tests__/VSlider.spec.ts:138:17) at Object.next (src/components/VSlider/__tests__/VSlider.spec.ts:69:14) at src/components/VSlider/__tests__/VSlider.spec.ts:41:67 at Object..__awaiter (src/components/VSlider/__tests__/VSlider.spec.ts:18:10) at Object. (src/components/VSlider/__tests__/VSlider.spec.ts:606:50) ● VSlider.ts › should be decreasing when reverse is set expect(received).toMatchSnapshot() Snapshot name: `VSlider.ts should be decreasing when reverse is set 2` - Snapshot + Received @@ -1,32 +1,32 @@ -
+
-
613 | wrapper.vm.$vuetify.rtl = true 614 | > 615 | expect(wrapper.html()).toMatchSnapshot() | ^ 616 | }) 617 | }) 618 | at Object. (src/components/VSlider/__tests__/VSlider.spec.ts:615:28) at step (src/components/VSlider/__tests__/VSlider.spec.ts:138:17) at Object.next (src/components/VSlider/__tests__/VSlider.spec.ts:69:14) at src/components/VSlider/__tests__/VSlider.spec.ts:41:67 at Object..__awaiter (src/components/VSlider/__tests__/VSlider.spec.ts:18:10) at Object. (src/components/VSlider/__tests__/VSlider.spec.ts:606:50) Snapshot Summary › 2 snapshots failed from 1 test suite. Inspect your code changes or run `yarn run test:unix -u` to update them. › 1 snapshot obsolete from 1 test suite. To remove it, run `yarn run test:unix -u`. ↳ src/components/VSlider/__tests__/VSlider.spec.ts • VSlider.ts should correctly handle setting value to zero (#7320) 1 Test Suites: 1 failed, 160 passed, 161 total Tests: 1 failed, 21 skipped, 1210 passed, 1232 total Snapshots: 2 failed, 1 obsolete, 486 passed, 488 total Time: 182.625s Ran all test suites. error Command failed with exit code 1. error Command failed with exit code 1. error Command failed with exit code 1. lerna ERR! yarn run test:coverage -i exited 1 in 'vuetify' ```
TravisBuddy Request Identifier: bab19080-84ef-11e9-ad8d-77d1a8aa9fed
sureshvv commented 4 years ago

Great, ty, still there are 2 other issues in my comment

Fixed 1. Can you check the keyboard input again? For 3 out of 4 cases in the playground, it seems to do the right thing. For the case of vertical slider, it seems counter intuitive if you look by direction. But if you look at it as "down" key decreases value and "up" key increases value it seems ok.

Should I fix just this one case (vertical slider with reverse)?

jacekkarczmarczyk commented 4 years ago

For me it's not intuitive for me when you press down arrow and slider goes up, don't know about team's opinion. Also i don't recall using vertical slider with keyboard at all, so won't force anything

There also a new issue: image

sureshvv commented 4 years ago

@jacekkarczmarczyk can you explain new issue? Have also fixed keyboard for vertical slider.

jacekkarczmarczyk commented 4 years ago

colors of the track and ticks are inverted in reverse mode

sureshvv commented 4 years ago

colors of the track and ticks are inverted in reverse mode

No idea how that happened :) will check.

jacekkarczmarczyk commented 4 years ago
  1. pageDown/pageUp are not handled properly - in vertical mode page UP should move UP, not sure what should be proper behaviour for horizontal
  2. home/end - imho in all cases (vertical/horizontal, and normal/reverse) home should set the initial value (5 for normal, 15 for reversed), end - the opposite
  3. RTL switches top/bottom in vertical slider

I'm starting to think that allowing min to be greater than max would be a better solution, also in terms of implementation...

sureshvv commented 4 years ago
  1. pageDown/pageUp are not handled properly - in vertical mode page UP should move UP, not sure what should be proper behaviour for horizontal
  2. home/end - imho in all cases (vertical/horizontal, and normal/reverse) home should set the initial value (5 for normal, 15 for reversed), end - the opposite

Will check.

  1. RTL switches top/bottom in vertical slider

How can I test RTL in the Playground?

I'm starting to think that allowing min to be greater than max would be a better solution, also in terms of implementation...

I think it will boil down to current implementation anyway at the end.

jacekkarczmarczyk commented 4 years ago

<v-checkbox v-model=$vuetify.rtl />

nekosaur commented 4 years ago

ping @sureshvv

johnleider commented 4 years ago

This issue is being closed due to: