search

vueuse / gesture

🕹 Vue Composables making your app interactive
https://gesture.vueuse.org
MIT License
353 stars 18 forks source link

Fix misspelled variable name in docs example #9

Closed uier closed 2 years ago

uier commented 3 years ago

@Tahul Hello!

Could you help me address netlify deploy failed issue?

The node version is incompatible but I didn't find node version specified in code (maybe it's in env?).

10:35:05 AM: Installing NPM modules using Yarn version 1.22.4
10:35:05 AM: yarn install v1.22.4
10:35:05 AM: [1/4] Resolving packages...
10:35:05 AM: [2/4] Fetching packages...
10:35:19 AM: info fsevents@2.3.2: The platform "linux" is incompatible with this module.
10:35:19 AM: info "fsevents@2.3.2" is an optional dependency and failed compatibility check. Excluding it from installation.
10:35:19 AM: error rollup-plugin-dts@3.0.2: The engine "node" is incompatible with this module. Expected version ">=v12.22.1". Got "12.18.0"
10:35:19 AM: error Found incompatible module.
10:35:19 AM: info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
10:35:19 AM: Error during Yarn install
10:35:19 AM: Build was terminated: Build script returned non-zero exit code: 1

Thanks!

Kapcash commented 2 years ago

Taking advantage of your opened PR to add that the handle function in use-wheel is the wrong function name. scrollHandler should be wheelHandler as this is the actual function in the script setup.

Could you add it to your PR so we don't open multiple "typo" PR? :D

Tahul commented 2 years ago

Thank you @Kapcash and @Uier!

And sorry for the late answer! 😄