vueuse / motion

🤹 Vue Composables putting your components in motion
https://motion.vueuse.org
MIT License
2.37k stars 82 forks source link

Wrong writing leads to loss of 'MayRef' responsiveness #125

Closed xiankq closed 7 months ago

xiankq commented 1 year ago

unref should be placed in computed like:


export function useMotionVariants<T extends MotionVariants>(variants: MaybeRef<T> = {} as MaybeRef<T>) {
  // Unref variants
   //↓↓↓↓↓↓↓
  // const _variants = unref(variants) as T

  // Current variant string
  const variant = ref() as Ref<keyof T>

  // Current variant state
  const state = computed<Variant | undefined>(() => {
    if (!variant.value) return
    //↓↓↓↓↓↓↓
    const _variants = unref(variants) as T
    return _variants[variant.value]
  })

  return {
    state,
    variant,
  }
}
BobbieGoede commented 8 months ago

Are you experiencing any issues related to the code you're talking about? Could you please provide a reproduction so I can look into it 🙏

github-actions[bot] commented 8 months ago

Would you be able to provide a reproduction? 🙏

More info ### Why do I need to provide a reproduction? Reproductions make it possible for us to triage and fix issues quickly with a relatively small team. It helps us discover the source of the problem, and also can reveal assumptions you or we might be making. ### What will happen? If you've provided a reproduction, we'll remove the label and try to reproduce the issue. If we can, we'll mark it as a bug and prioritize it based on its severity and how many people we think it might affect. If `needs reproduction` labeled issues don't receive any substantial activity (e.g., new comments featuring a reproduction link), we'll close them. That's not because we don't care! At any point, feel free to comment with a reproduction and we'll reopen it. ### How can I create a reproduction? A link to a stackblitz project or public GitHub repository would be perfect. 👌 Please ensure that the reproduction is as **minimal** as possible. You might also find these other articles interesting and/or helpful: - [The Importance of Reproductions](https://antfu.me/posts/why-reproductions-are-required) - [How to Generate a Minimal, Complete, and Verifiable Example](https://stackoverflow.com/help/minimal-reproducible-example)
github-actions[bot] commented 7 months ago

This issue was closed because it was open for 7 days without a reproduction.