Allow GUIDs as primary key instead of just numbers (and fix typings)

vuex-orm / plugin-graphql

Vuex ORM persistence plugin to sync the store against a GraphQL API.

https://vuex-orm.github.io/plugin-graphql/

MIT License

227 stars 52 forks source link

Closed timvandesteeg closed 3 years ago

timvandesteeg commented 3 years ago

toNumber() is only used to parse IDs, so I recommend changing it to toPrimaryKey and also allow GUIDs.
also added the possibility to override the singularName or pluralName from the source Model
and fixed the misconfigured typings from https://github.com/vuex-orm/plugin-graphql/issues/158

phortx commented 3 years ago

Hi @timvandesteeg ,

thank you very much for your contribution! :)

Could you please provide tests for overwriting the singular/plural name and also for using GUIDs?

timvandesteeg commented 3 years ago

Added the tests :) Compliments for this plugin by the way. Love the abstraction it provides!

phortx commented 3 years ago

Looks good :)

Thank you very much for the kind words. Would be nice when I'd have more time for this project :(

phortx commented 3 years ago