search

vugu / vugu

Vugu: A modern UI library for Go+WebAssembly (experimental)
https://www.vugu.org
MIT License
4.8k stars 175 forks source link

Go 1.16 and 1.17 support #218

Closed sorenisanerd closed 2 years ago

sorenisanerd commented 2 years ago

From the release notes for Go 1.161:

"Build commands like go build and go test no longer modify go.mod
 and go.sum by default. Instead, they report an error if a module
 requirement or checksum needs to be added or updated (as if the
 -mod=readonly flag were used). Module requirements and sums may
 be adjusted with go mod tidy or go get."

To accommodate this change we either need to create fully populated go.mod and go.sum or call go mod tidy to satisfy go build.

go mod tidy seemed (by far) preferable, so now we call that at strategic places in the tests as well as in the dev server handler.

bradleypeabody commented 2 years ago

Hi @sorenisanerd Can you please summarize (explain) the key changes? It will be easier to merge if we break some of these things down. I like the idea of moving to GitHub actions but I think that could just be one PR and we do that as one thing. On some of the other changes I don't follow for example why "go mod tidy" is being run in these various places, or what the purpose of some of other changes is.

sorenisanerd commented 2 years ago

Yeah, sorry, didn't mean to include the GitHub Actions thing in this PR. I'll get rid of it and write a better commit message :)

sorenisanerd commented 2 years ago

It doesn't make a whole lot of sense to not have the travis -> actions change here, since I have to change the test matrix, but I've sent a PR for it, so it can be reviewed first and separately.

Also updated the description of this PR.

bradleypeabody commented 2 years ago

Thanks for this! Looks good, merging. I think the GitHub actions stuff will need to have the TinyGo compiler added but it seems fine to start with this.