search

vukhanhtruong / jquery-elastic-grid

jQuery Elastic Grid is a lightweight, easy to use gallery jquery plugin script inspired by Google Image Search with support for .PNG, .JPG and .GIF image files. It uses a thumbnail grid with expanding preview for displaying your images. It is also fully HTML5 and CSS3 compliant.
56 stars 32 forks source link

Tag Filter not working with more than 2 words #14

Open glerendegui opened 6 years ago

glerendegui commented 6 years ago

If a tag has more than 2 words, or more specifically more than 1 white spaces, then filter doesn't work.

The problem is about using javascript replace, that only change the first instance (https://www.w3schools.com/jsref/jsref_replace.asp)

To fix this you can change all instance of replace(' ','-') to replace(/ /g,'-')

here: // Looping though all the li items: -> items.each -> elem.addClass(...) here: porfolio_filter.find('a').bind('click',function(e){ -> var filterVal = .... and here: function createList(text){ -> var filter = text.....

glerendegui commented 6 years ago

Also, I think some will go wrong if showAllText has more than 2 word as it also uses replace(' ',...