vuki656 / package-info.nvim

✍️ All the npm/yarn/pnpm commands I don't want to type
GNU General Public License v3.0
480 stars 27 forks source link

[BUG] setting wrong colors #134

Closed pedro757 closed 1 year ago

pedro757 commented 1 year ago

Issues

Plugin Version

Neovim Version

Neovim Version

NVIM v0.9.0-dev-47-gcfdb4cbad

Branch

master

Actual behavior

image

Expected behavior

I expect to set the right colors

Steps to reproduce

require("package-info").setup()

Package info config

require("package-info").setup()

Other information

No response

Help

No, sorry.

Implementation help

No response

vuki656 commented 1 year ago

Can you run highlight PackageInfoOutdatedVersion and comment what you get

pedro757 commented 1 year ago

if I run it myself it changes the colors

:highlight PackageInfoOutdatedVersion guibg=#000000 guifg=#000000

image

vuki656 commented 1 year ago

No i meant just the command like so

image

pedro757 commented 1 year ago

PackageInfoOutdatedVersion xxx cleared

vuki656 commented 1 year ago

Seems like it's getting overridden somewhere, can you try and disable all other plugins and check if it still happens?

NiloDrumond commented 1 year ago

I don't know if this is still relevant, but I was also having this issue while using tokyonight. To be honest I'm not sure if that was the source of the problem, as I didn't actually test.

However, for those in the future that face the same problem, you can easily set the highlights back with tokyonight:

  on_highlights = function(hl, c)
    hl.PackageInfoOutdatedVersion = { fg = c.red1, }
    hl.PackageInfoUptodateVersion = { fg = c.green1, }
  end,
lucasrabiec commented 1 year ago

For those that face the same problem with dracula.nvim theme, you need to add to overrides something similar like in the comment above:

overrides = {
  ...
  PackageInfoOutdatedVersion = { fg = colors.bright_red },
  PackageInfoUptodateVersion = { fg = colors.bright_green },
}