vuki656 / package-info.nvim

✍️ All the npm/yarn/pnpm commands I don't want to type
GNU General Public License v3.0
480 stars 27 forks source link

[FEATURE REQUEST] Update Readme keymap config examples with description #137

Open dzintars opened 1 year ago

dzintars commented 1 year ago

Issues

Feature description

I would suggest to update key binding examples to:

vim.api.nvim_set_keymap(
    "n",
    "<leader>ns",
    "<cmd>lua require('package-info').show()<cr>",
    { silent = true, noremap = true, desc = "package-info | Show" }
)

Note the , desc = "package-info | Show" addition.

While this is "opinionated" thing to do, I do believe that newer Nvim users will benefit of cleaner :map n or :Telescope keymaps or which-key key descriptions. This enables easier duplicate keybinding finding and seeing "what is what and from where does it comes".

Also, examples could be improved with vim.keymap.set()

Help

Yes

Implementation help

No response

vuki656 commented 1 year ago

Makes sense. Feel free to open a PR.