search

vuki656 / package-info.nvim

✍️ All the npm/yarn/pnpm commands I don't want to type
GNU General Public License v3.0
480 stars 27 forks source link

[BUG] vim.json requires Neovim HEAD #88

Closed delianides closed 2 years ago

delianides commented 2 years ago

Issues

Plugin Version

Neovim Version

Neovim Version

NVIM v0.6.0-dev+557-g5ce35abae Build type: Release LuaJIT 2.1.0-beta3 Compiled by drew@Andrews-MBP-3.localdomain Features: +acl +iconv +tui See ":help feature-compile" system vimrc file: "$VIM/sysinit.vim" fall-back for $VIM: "/usr/local/Cellar/neovim/HEAD-5ce35ab_1/share/nvim" Run :checkhealth for more info

Branch

master

Actual behavior

Received error: attempt to index field 'json_parser' (a nil value)

Expected behavior

Package versions load as virtual text

Steps to reproduce

Run Neovim 0.5.1, you should see the error. Install Neovim from HEAD 0.6.0-dev and the plugin works fine.

Package info config

{ package_manager = "npm" ]

Other information

Not sure if its desired to force users to run Neovim from HEAD since 0.5 has shipped. It might make more sense to version check and just fallback to the previous json parser.

Help

Yes

Implementation help

No response

delianides commented 2 years ago

@mhartington #84

vuki656 commented 2 years ago

My bad for not checking if it's compatible with 0.5 will make sure in future PRs.

I'll merge #89 as soon as the build passes.

alxndr commented 2 years ago

Ah, is this why I'm seeing an error after updating?

.../paqs/start/package-info.nvim/lua/package-info/utils.lua:93: attempt to index upvalue 'json_parser' (a nil value)
vuki656 commented 2 years ago

Ah, is this why I'm seeing an error after updating?

.../paqs/start/package-info.nvim/lua/package-info/utils.lua:93: attempt to index upvalue 'json_parser' (a nil value)

Yup, just waiting on Mike to fix the build, and will be merged.