Change One Dependency to Add Support for Web Apps and Get 10 more Pub Points.

vukoye / xmpp_dart

Lightweight XMPP client library written in Dart

Apache License 2.0

83 stars 64 forks source link

Change One Dependency to Add Support for Web Apps and Get 10 more Pub Points. #64

Open CalebSturges opened 3 years ago

CalebSturges commented 3 years ago

Lack of Web App support in 'io' dependency is costing 10 pub points and preventing compilation to JavaScript. Replacing 'io' in this line to 'universal_io' would not change any of the native features- it uses 'io' outside of JavaScript, but would add support for local web apps. I can make a pull request or start a branch 'web_app_support' based on 'null_saftey'.

TatankaConCube commented 3 years ago

There is not enough to just exchange the dart:io to the universal_io. The universal_io doesn't support WebSocket connection for the Web and anyway needs to adapt the Connection.dart for working with Web (via WebSocketChannel I suppose).

CalebSturges commented 2 years ago

Well it looks like universal_io was added and according to pubdev the newest prerelease (https://pub.dev/packages/xmpp_stone/versions/0.4.3-dev.1/score) supports web apps so this issue can probably be changed to resolved. #https://github.com/vukoye/xmpp_dart/commit/95ee3f5a6996ffbb06e41be8723f91498055ea2e