search

vukoye / xmpp_dart

Lightweight XMPP client library written in Dart
Apache License 2.0
83 stars 64 forks source link

Merging to master #74

Closed npsopheak closed 2 years ago

npsopheak commented 2 years ago

Merging to master

vukoye commented 2 years ago

Nice progress there @npsopheak It's really large PR and I am trying to wrap my head around it. I have few basic questions before going deeper into the code: 1) Why you haven't used null_safety branch as starting point, as it was the base branch for latest dev releases? 2) Why is the reason for changing the library name to xmpp_stone_obelisk?

vukoye commented 2 years ago

@npsopheak Also license is changed and your name is there?

npsopheak commented 2 years ago

Hi thank for reaching out,

For license, I was testing to see because this is my first time , so it was there but I can revoke it.

For the null safety branch, I did not realize it until I finish already but I think I can try to see to sync it up.

For changing the name, because I tried to put a test to the project so I can easily find and revert back because we are using other library build with bridge to other.

If you are fine, I can revert back and try to clean it and raise 1 PR for you if that okay.

  1. Revert license and name
  2. Merge safety branch (if it is okay)
  3. Merge back to your Repo via PR

On Mon, 27 Dec 2021 at 5:04 AM vukoye @.***> wrote:

@npsopheak https://github.com/npsopheak Also license is changed and your name is there?

— Reply to this email directly, view it on GitHub https://github.com/vukoye/xmpp_dart/pull/74#issuecomment-1001247068, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJDJWXEEKNXS74XMHZHNF3US6GOBANCNFSM5KUR24UA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Sean (Promsopeak) Nuon,

Solution Architectwww.slash.co http://www.slash.co/Build Studio - Teams to Innovate

https://www.linkedin.com/company/slash-co https://www.facebook.com/slashfoundry https://www.instagram.com/slash_co_/

https://clutch.co/profile/slash

npsopheak commented 2 years ago

Sorry for the large PR I was testing a lot chunk of it while doing some integration to test back and forward.

On Mon, 27 Dec 2021 at 4:49 AM vukoye @.***> wrote:

Nice progress there @npsopheak https://github.com/npsopheak It's really large PR and I am trying to wrap my head around it. I have few basic questions before going deeper into the code:

  1. Why you haven't used null_safety branch as starting point, as it was the base branch for latest dev releases?
  2. Why is the reason for changing the package to xmpp_stone_obelisk?

— Reply to this email directly, view it on GitHub https://github.com/vukoye/xmpp_dart/pull/74#issuecomment-1001245809, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJDJWTHENANYUWGKSX6VBTUS6EWRANCNFSM5KUR24UA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Sean (Promsopeak) Nuon,

Solution Architectwww.slash.co http://www.slash.co/Build Studio - Teams to Innovate

https://www.linkedin.com/company/slash-co https://www.facebook.com/slashfoundry https://www.instagram.com/slash_co_/

https://clutch.co/profile/slash

npsopheak commented 2 years ago

I will work on it more tomorrow, today I am off, so I will let you know after tomorrow

On Mon, 27 Dec 2021 at 8:42 AM Sean (Promsopheak) Nuon @.***> wrote:

Sorry for the large PR I was testing a lot chunk of it while doing some integration to test back and forward.

On Mon, 27 Dec 2021 at 4:49 AM vukoye @.***> wrote:

Nice progress there @npsopheak https://github.com/npsopheak It's really large PR and I am trying to wrap my head around it. I have few basic questions before going deeper into the code:

  1. Why you haven't used null_safety branch as starting point, as it was the base branch for latest dev releases?
  2. Why is the reason for changing the package to xmpp_stone_obelisk?

— Reply to this email directly, view it on GitHub https://github.com/vukoye/xmpp_dart/pull/74#issuecomment-1001245809, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJDJWTHENANYUWGKSX6VBTUS6EWRANCNFSM5KUR24UA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Sean (Promsopeak) Nuon,

Solution Architectwww.slash.co http://www.slash.co/Build Studio - Teams to Innovate

https://www.linkedin.com/company/slash-co https://www.facebook.com/slashfoundry https://www.instagram.com/slash_co_/

https://clutch.co/profile/slash

-- Sean (Promsopeak) Nuon,

Solution Architectwww.slash.co http://www.slash.co/Build Studio - Teams to Innovate

https://www.linkedin.com/company/slash-co https://www.facebook.com/slashfoundry https://www.instagram.com/slash_co_/

https://clutch.co/profile/slash

npsopheak commented 2 years ago

Oh forgot, I put the MIT license so I think there is no name. But i will revert for you to put instead.

On Mon, 27 Dec 2021 at 8:43 AM Sean (Promsopheak) Nuon @.***> wrote:

I will work on it more tomorrow, today I am off, so I will let you know after tomorrow

On Mon, 27 Dec 2021 at 8:42 AM Sean (Promsopheak) Nuon @.***> wrote:

Sorry for the large PR I was testing a lot chunk of it while doing some integration to test back and forward.

On Mon, 27 Dec 2021 at 4:49 AM vukoye @.***> wrote:

Nice progress there @npsopheak https://github.com/npsopheak It's really large PR and I am trying to wrap my head around it. I have few basic questions before going deeper into the code:

  1. Why you haven't used null_safety branch as starting point, as it was the base branch for latest dev releases?
  2. Why is the reason for changing the package to xmpp_stone_obelisk?

— Reply to this email directly, view it on GitHub https://github.com/vukoye/xmpp_dart/pull/74#issuecomment-1001245809, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJDJWTHENANYUWGKSX6VBTUS6EWRANCNFSM5KUR24UA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were mentioned.Message ID: @.***>

-- Sean (Promsopeak) Nuon,

Solution Architectwww.slash.co http://www.slash.co/Build Studio - Teams to Innovate

https://www.linkedin.com/company/slash-co https://www.facebook.com/slashfoundry https://www.instagram.com/slash_co_/

https://clutch.co/profile/slash

-- Sean (Promsopeak) Nuon,

Solution Architectwww.slash.co http://www.slash.co/Build Studio - Teams to Innovate

https://www.linkedin.com/company/slash-co https://www.facebook.com/slashfoundry https://www.instagram.com/slash_co_/

https://clutch.co/profile/slash

-- Sean (Promsopeak) Nuon,

Solution Architectwww.slash.co http://www.slash.co/Build Studio - Teams to Innovate

https://www.linkedin.com/company/slash-co https://www.facebook.com/slashfoundry https://www.instagram.com/slash_co_/

https://clutch.co/profile/slash

vukoye commented 2 years ago

@npsopheak Thanks for the explanation and contribution. Sure, I would be happy to include changes to the library.

npsopheak commented 2 years ago

Hi @vukoye, I think it might contain breaking changes for some users, maybe we can put it to some alpha branch first? and release as alpha release, I would love to contribute for these period of time, because I love to see dart/flutter having xmpp as it own :D

I just revert the package name and license.

npsopheak commented 2 years ago

I think I have closed for now, because too many changes. and have not clean up.