search

vulcan-api / spito

spito is a powerful config management system
https://vulcan-api.github.io/spito/
GNU General Public License v3.0
3 stars 0 forks source link

go checker #23

Closed BaderBC closed 10 months ago

BaderBC commented 11 months ago

Closes #21

maxidragon commented 10 months ago

Anyway, I think the way of storing rules is an issue that need to be discussed.

I agree with you. We should discuss it at our next meeting

BaderBC commented 10 months ago

Please don't use panic. Anyway, I think the way of storing rules is an issue that need to be discussed. Downloading and immediately deleting after use isn't good idea IMO. Moreover, when I saw function checking URL, I immediately thought of a library that should do this for us and should be available on the internet.

1) That was a draft, now everything looks different 2) Speaking about using panic, it's much more complicated than I thought. I cannot use error propagation because CheckRule function is directly invoked from lua. That's why I cannot propagate error higher that CheckRule. I was thinking about calling some function which will send appropriate message to CLI / GUI and then exit with code 1. But for now we have neither CLI nor GUI