vulcan-api / spito

spito is a powerful config management system
https://vulcan-api.github.io/spito/
GNU General Public License v3.0
3 stars 0 forks source link

Add the ability to create new ruleset and new rule #47

Closed sewe2000 closed 10 months ago

sewe2000 commented 10 months ago

Resolves #35

sewe2000 commented 10 months ago

I suggest changing names of these commands: nr or new rule - to create rule ns or new set - to create set

@BaderBC What do you think about it?

BaderBC commented 10 months ago

I suggest changing names of these commands: nr or new rule - to create rule ns or new set - to create set

@BaderBC What do you think about it?

Even though It sounds good I'm not sure whether it is necessary, especially that new rule isn't the command which would be often used.

sewe2000 commented 10 months ago

I suggest changing names of these commands: nr or new rule - to create rule ns or new set - to create set

@BaderBC What do you think about it?

Even though It sounds good I'm not sure whether it is necessary, especially that new rule isn't the command which would be often used.

The thing is I've implemented the process of creating a new rule, but the command is generate {rule_name}````. @cooligus suggested to change it tonew rule {rule_name}```

BaderBC commented 10 months ago

I suggest changing names of these commands: nr or new rule - to create rule ns or new set - to create set

@BaderBC What do you think about it?

Even though It sounds good I'm not sure whether it is necessary, especially that new rule isn't the command which would be often used.

The thing is I've implemented the process of creating a new rule, but the command is generate {rule_name}````. @cooligus suggested to change it tonew rule {rule_name}```

Okay, Now I understand. Personally i prefer to do it the same way Nest.js cli did it - generate