vulcand / oxy

Go middlewares for HTTP servers & proxies
Apache License 2.0
2.02k stars 324 forks source link

Add a mechanism to control the sticky cookie value #216

Closed jbdoumenjou closed 3 years ago

jbdoumenjou commented 3 years ago

What does this PR do?

Add a mechanism to format the sticky cookie value. It introduces a CookieValue interface to allow implementations to control the sticky cookie value.

There are several implementations available:

Motivation

This PR is inspired by #184 and #203 and provides a flexible way to manage the cookie value and some basic implementations.

closes #184 closes #203

Additional Notes

Co-authored-by: Tom Moulard tom.moulard@traefik.io Co-authored-by: M m@cognusion.com Co-authored-by: Sylvain Rabot sylvain@abstraction.fr

sylr commented 3 years ago

I wish that you would keep our commits as we sent them so that the git history reflects the effort that both @cognusion and I put into this.

By squashing them you discard all authorship information.

ldez commented 3 years ago

The 2 PRs were not compatible and the work to merge them was more important than creating a new PR.

The 2 PRs are referenced in the PR description, and you are flagged as co-author of this PR.

And when I will merge, I will set you as co-author.

In all cases, the commits in a PR are always squashed when we merge.

cognusion commented 3 years ago

I am :100: ok with this, philosophically. I have not reviewed the commit for technical merits.

pavelmarek77 commented 3 years ago

Please may I know when this will be part of a release? Is there way to get notified?

ldez commented 3 years ago

@pavelmarek77 a release of oxy or Traefik?

For oxy, there is a tag v1.3.0. For Traefik, you can follow https://github.com/traefik/traefik/pull/8103

pavelmarek77 commented 3 years ago

@ldez I meant Traefik. Thank you!