search

vulcand / vulcan

[DEPRECATING] Development has moved to https://github.com/vulcand/oxy
Apache License 2.0
357 stars 33 forks source link

Use X-Forwarded-Proto when we TrustFowardHeader #55

Closed jbardin closed 10 years ago

jbardin commented 10 years ago

If vulcan is behind another proxy/lb, we may need to keep the X-Forwarded-Proto header from the incoming request

jbardin commented 10 years ago

We're trying to use vulcan behind an AWS ELB, but we need to have the original request protocol, not that from the ELB.

klizhentas commented 10 years ago

James,

Are you using vulcan library or vulcand? I'm thinking of moving this function to vulcand as a middleware.

jbardin commented 10 years ago

This is using the vulcan library directly. We already had a Go load balancer, and vulcan allowed us to quickly embed an http proxy for host-based routing.

klizhentas commented 10 years ago

Ok, makes sense. I would keep this logic in the library then. Can you add tests to cover this scenario?Otherwise looks good to me

jbardin commented 10 years ago

OK. Added a test for headers

klizhentas commented 10 years ago

Thanks James!