roysc
commented
3 years ago ADR-040: Updates for SMT
As part of the proposed ADR-040, we want to update the SMT data structure so it can use Tendermint DB as a node database. This will entail implementing the MapStore interface for tm-db and its new backends, RocksDB and BadgerDB.
Batching
Batched writes are already implemented in tm-db for both backends. These could simply be wrapped in a method on SmapStore, but there is no clear benefit to using them in the SMT for the currently implemented operations. However, if we want to implement efficient batched writes to the SMT itself, that could also be supported in the following way.
The tree will need to be able to read as well as write to the batch itself while building it, using something closer to a transaction object.
- RocksDB has a Write Batch With Index utility which allows this.
- BadgerDB's
WriteBatchdoes not supportGets, but, as it is a relatively simple wrapper around a transaction, we could just useTxn.
These types would be wrapped in the MapStore interface. The SMT would need a new interface type to represent the batch (e.g. WriteBatch). This would wrap a derived SparseMerkleTree object using the transaction object as its MapStore.
Versioning & snapshots
Creating state sync snapshots is not required for SMT data. https://github.com/cosmos/cosmos-sdk/pull/8430#discussion_r626879836.
It seems versioning is also not needed, but it's not entirely clear. However, if so, this could be implemented with a MapStore.GetAt([]byte, uint64) method, which forwards to a (new) tmdb.DB.GetAt([]byte, uint64) method, implemented like so:
- BadgerDB in managed mode allows arbitrary integers to be used as "timestamp" versions, so this can basically be forwarded directly.
- For RocksDB, a
Checkpointcan be created for each commit in a path corresponding to the version integer, and then used as a read-only copy of the DB.
Outline precisely how we will support both using the MapStore interface (with batching, versioning, and DB snapshotting).