search

vulcanlink / charts

Vulcan Link Helm Chart Repo
21 stars 8 forks source link

Add option to preset key in the ethereum keystore #23

Closed svetomir closed 3 years ago

svetomir commented 3 years ago

This PR allows pre-setting of a key (and appropriate password) in the ethereum data dir.

If Values.key and Values.password are specified, (by default) they will be saved in following files, respectively: /root/.ethereum/keystore/key.json /root/.ethereum/password

Both, key and password are kept in a Kubernetes secrets.

svetomir commented 3 years ago

See comments regarding conditional statements on secret.yaml

Can you also update the README file to add your options to the table?

Thank you for the review. I pushed the changes.

leovigna commented 3 years ago

lgtm. I will soon merge this to the master branch and deploy it to the chart repository.