search

vulcu / dahlia

Waveshaping Polyphonic Synthesis for the Heavy Compiler Collection
GNU General Public License v3.0
4 stars 0 forks source link

Note input responds to both on and off messages #17

Closed dromer closed 10 months ago

dromer commented 10 months ago

You probably want to add [stripnote] (bugfix on hvcc pending) so you can treat the note-off separately.

vulcu commented 10 months ago

thanks! So, the envelope generator in voice.pd already tests for note on (velocity > 0) or noteoff (velocity == 0) and uses that to send the correct line values for the relevant envelope stage ('attack' or 'release') to the |hv.vline~| component. What is the bug in hvcc, is it not handling this correctly somehow?

vulcu commented 10 months ago

also, really appreciate your feedback on these issues!

dromer commented 10 months ago

I didn't test this with hvcc yet, but I tried the pd patch and it creates notes on both on and off events :shrug:

In hvcc you currently have to use [pack f f] to send the note+velocity into the left inlet of [stripnote], but I have a pending fix so that you can send the velocity to the right inlet as well: https://github.com/Wasted-Audio/hvcc/issues/149

And no problem! I randomly stumbled on your project and figured I'd give some input to help it move forward :)

vulcu commented 10 months ago

yup, definitely a bug -- the portamento patch is retriggering the note during note-off events, looks like a copy-paste error on my part. Should be limited to the monophonic voicing. Great catch! :)