vulkano-rs / vulkano

Safe and rich Rust wrapper around the Vulkan API
Apache License 2.0
4.49k stars 432 forks source link

Show warnings generated by glslang #117

Open tomaka opened 8 years ago

tomaka commented 8 years ago

Once https://github.com/rust-lang/cargo/pull/2630 lands

rukai commented 5 years ago

glsl-to-spirv is no more. https://github.com/vulkano-rs/vulkano/pull/947

nicokoch commented 5 years ago

Could warnings be shown regardless? shaderc uses glsl internally. Or are they shown already? Haven't really used vulkano recently.

rukai commented 5 years ago

Good point, in fact, shaderc makes it really easy to get. https://docs.rs/shaderc/0.3.11/shaderc/struct.CompilationArtifact.html#method.get_warning_messages

Rua commented 2 years ago

The feature linked by Tomaka isn't actually relevant here, because Vulkano-shaders is a procedural macro rather than a build script. Emitting warnings from a procedural macro is possible via the proc_macro_error crate, but this is not possible on stable Rust yet because it's blocked by this feature.