vulkano-rs / vulkano

Safe and rich Rust wrapper around the Vulkan API
Apache License 2.0
4.48k stars 433 forks source link

Vulkano Needs `MutableDescriptorSet` #2464

Closed joshua-holmes closed 7 months ago

joshua-holmes commented 7 months ago

Issue

The PersistentDescriptorSet is designed to be immutable (the update method is private), which works great if I don't want to update my descriptor set. However, I do, and using UnsafeDescriptorSet by itself doesn't work because, unlike with PersistentDescriptorSet, I can't bind UnsafeDescriptorSet using the AutoCommandBufferBuilder::bind_descriptor_sets method, because neither UnsafeDescriptorSet nor Vec<UnsafeDescriptorSet> implements DescriptorSetsCollection trait.

Are there plans to add a MutableDescriptorSet struct that implements DescriptorSetsCollection, similar to PersistentDescriptorSet, but with a public update method? If not, can there be plans to do so? I would be happy to implement it and make a PR, if that's helpful. Thanks!

Rua commented 7 months ago

This was added by #2404 and will be part of the next Vulkano release, 0.35.

joshua-holmes commented 7 months ago

Oh awesome, looking forward to it! Thanks for the response!