search

vulkano-rs / vulkano

Safe and rich Rust wrapper around the Vulkan API
Apache License 2.0
4.48k stars 433 forks source link

Up vk version in shader compilation #2467

Closed maratik123 closed 7 months ago

maratik123 commented 7 months ago

This fixes #2468

  1. [-] Update documentation to reflect any user-facing changes - in this repository.

  2. [+] Make sure that the changes are covered by unit-tests.

  3. [+] Run cargo clippy on the changes.

  4. [+] Run cargo +nightly fmt on the changes.

  5. [+] Please put changelog entries in the description of this Pull Request if knowledge of this change could be valuable to users. No need to put the entries to the changelog directly, they will be transferred to the changelog file by maintainers right after the Pull Request merge.

    Please remove any items from the template below that are not applicable.

  6. [+] Describe in common words what is the purpose of this change, related Github Issues, and highlight important implementation aspects.

Changelog:

### Additions
- Support for Vulkan 1.3 target environment in shader compilation.
Rua commented 7 months ago

The clippy warnings are fixed by #2462, so you don't need to fix those yourself.

maratik123 commented 7 months ago

The clippy warnings are fixed by #2462, so you don't need to fix those yourself.

PR was merged with upstream

marc0246 commented 4 months ago

Note that you have to update the version of shaderc to the version that added the enum variant in the Cargo.toml, as currently someone that has e.g. shaderc 0.8.2 in their Cargo.lock will fail compilation.