[X] Update documentation to reflect any user-facing changes - in this repository.
N/A
[X] Make sure that the changes are covered by unit-tests.
Covered already in debug example binary.
[X] Run cargo clippy on the changes.
None new, some exist already upstream.
[X] Run cargo +nightly fmt on the changes.
[X] Please put changelog entries in the description of this Pull Request
if knowledge of this change could be valuable to users. No need to put the
entries to the changelog directly, they will be transferred to the changelog
file by maintainers right after the Pull Request merge.
Please remove any items from the template below that are not applicable.
[X] Describe in common words what is the purpose of this change, related
Github Issues, and highlight important implementation aspects.
A simple check for null pointers in the debug callback. My current device (Mesa 24.0.2-arch1.1 on device Intel(R) HD Graphics 2500 (IVB GT1)) reports a null pointer with count of zero for empty arrays - this is allowable under the vulkan spec for VkDebugUtilsMessengerCallbackDataEXT but is invalid for use in slice::from_raw_parts which needs a well-aligned non-null pointer part even for zero length slices.
Changelog:
### Bugs fixed
Fix UB in debug messenger when driver reports null pointers for empty arrays.
[X] Update documentation to reflect any user-facing changes - in this repository. N/A
[X] Make sure that the changes are covered by unit-tests. Covered already in
debug
example binary.[X] Run
cargo clippy
on the changes. None new, some exist already upstream.[X] Run
cargo +nightly fmt
on the changes.[X] Please put changelog entries in the description of this Pull Request if knowledge of this change could be valuable to users. No need to put the entries to the changelog directly, they will be transferred to the changelog file by maintainers right after the Pull Request merge.
Please remove any items from the template below that are not applicable.
[X] Describe in common words what is the purpose of this change, related Github Issues, and highlight important implementation aspects.
A simple check for null pointers in the debug callback. My current device (
Mesa 24.0.2-arch1.1
on deviceIntel(R) HD Graphics 2500 (IVB GT1)
) reports a null pointer with count of zero for empty arrays - this is allowable under the vulkan spec forVkDebugUtilsMessengerCallbackDataEXT
but is invalid for use inslice::from_raw_parts
which needs a well-aligned non-null pointer part even for zero length slices.Changelog: