PhysicalDevice::surface_present_modes should return Vec result as any other this struct functions for consistency and to eliminate composing result back to Vec in outer crate usages, such as:
[ ] Update documentation to reflect any user-facing changes - in this repository.
[ ] Make sure that the changes are covered by unit-tests: no unit-test exists to cover these functions
[x] Run cargo clippy on the changes.
[x] Run cargo +nightly fmt on the changes.
[x] Please put changelog entries in the description of this Pull Request
if knowledge of this change could be valuable to users. No need to put the
entries to the changelog directly, they will be transferred to the changelog
file by maintainers right after the Pull Request merge.
Please remove any items from the template below that are not applicable.
[x] Describe in common words what is the purpose of this change, related
Github Issues, and highlight important implementation aspects.
Changelog:
### Breaking changes
Changes to `PhysicalDevice`:
- Return type of function `surface_present_modes` changed to `Result<Vec<PresentMode>, VulkanError>`.
- Return type of function `surface_present_modes_unchecked` changed to `Result<Vec<PresentMode>, VulkanError>`.
PhysicalDevice::surface_present_modes
should returnVec
result as any other this struct functions for consistency and to eliminate composing result back toVec
in outer crate usages, such as:[ ] Update documentation to reflect any user-facing changes - in this repository.
[ ] Make sure that the changes are covered by unit-tests: no unit-test exists to cover these functions
[x] Run
cargo clippy
on the changes.[x] Run
cargo +nightly fmt
on the changes.[x] Please put changelog entries in the description of this Pull Request if knowledge of this change could be valuable to users. No need to put the entries to the changelog directly, they will be transferred to the changelog file by maintainers right after the Pull Request merge.
Please remove any items from the template below that are not applicable.
[x] Describe in common words what is the purpose of this change, related Github Issues, and highlight important implementation aspects.
Changelog: