vulkano-rs / vulkano

Safe and rich Rust wrapper around the Vulkan API
Apache License 2.0
4.45k stars 435 forks source link

Integrate latest vk.xml changes #2513

Closed 0xcaff closed 4 months ago

0xcaff commented 4 months ago

Overview

Pulls in the vk.xml used in ash 0.38 (https://github.com/KhronosGroup/Vulkan-Headers/blob/38899bf60605f0a2c50f7968e5c4c9826a824683/registry/vk.xml) adding stuff to autogen to get it compiling.

Merge Order

This is ready to merge. It depends on:

  1. https://github.com/vulkano-rs/vulkano/pull/2512
  2. https://github.com/vulkano-rs/vulkano/pull/2511
  3. https://github.com/vulkano-rs/vulkano/pull/2510

all of which are merged.

Changelog

### Additions
- Update vk.xml to [Vulkan-Headers@38899bf](https://github.com/KhronosGroup/Vulkan-Headers/blob/38899bf60605f0a2c50f7968e5c4c9826a824683/registry/vk.xml) to match version used in ash 0.38
Rua commented 4 months ago

Would it be possible to add definitions for the two types you've added to the physical device module? It doesn't have to be documented, but at least give the user the ability to read the property.

0xcaff commented 4 months ago

I've updated it here, https://github.com/vulkano-rs/vulkano/pull/2513/commits/a60ab3a5b57596490c006984542840578d1a2657

How does this look?

Rua commented 4 months ago

I meant defining them using the vulkan_enum! and vulkan_bitflags! macros, following the definitions in the Vulkan spec:

0xcaff commented 4 months ago

ahh I see ok good idea, updated!

Rua commented 4 months ago

Thanks!