vulkano-rs / vulkano

Safe and rich Rust wrapper around the Vulkan API
Apache License 2.0
4.45k stars 435 forks source link

Allow memory interface blocks to have offset decorations on first member #2535

Closed chaynabors closed 1 month ago

chaynabors commented 2 months ago

fixes https://github.com/vulkano-rs/vulkano/issues/2534

There is likely a better, much more involved solution here.

The offending struct only contains the following decorations per spirv [Decorate { target: Id(14), decoration: Block }]

That doesn't look like an indication that this is a push constant declaration to me, so discriminating against this might mean passing additional data alongside the spirv from source. Since I don't know the spec well enough to know if this is actually useful or valid for non push-constant declarations, this is the best I can offer.

Rua commented 1 month ago

I don't immediately see any problems that could occur due to this, so it may just be Vulkano being overly conservative on its sanity checks. We'll see if anything turns up later.