search

vulkano-rs / vulkano

Safe and rich Rust wrapper around the Vulkan API
Apache License 2.0
4.45k stars 435 forks source link

See if 0 (but not None) timeout would solve crash #2543

Open hakolao opened 1 month ago

hakolao commented 1 month ago

Potential help for #2524

I can't repro the issue on my Windows machine, so unsure what to do. This fix may potentially help.

daveh86 commented 1 month ago

Just ran a check on this myself as I could repro.

Some(0) fails, but None succeeds, so looks like the issue.

Digging through, it looks like the timeout just defaults to u64::Max so I went the other way and increased the timeouts.

For my Linux box (arch + plasma + wayland + nvidia prop driver), a timeout of 25ms seems sufficient when the window is in focus. However, while writing this comment i noted that the crash would occur when I swapped focus to Firefox, meaning the pipeline is slowed or halted when the window is not in focus.

Rua commented 1 month ago

Why not just use a timeout of 1 second? That's more than is reasonably enough.

hakolao commented 1 month ago

Why not just use a timeout of 1 second? That's more than is reasonably enough.

Let's try that

Rua commented 1 month ago

Yeah that fixed it.