vulnersCom / api

Vulners Python API wrapper
GNU General Public License v3.0
356 stars 60 forks source link

Fix for logging in ratelimit.py #28

Closed nevermort closed 2 years ago

nevermort commented 2 years ago

Hi folks, could you please explain for what purpose the logging library is used in ratelimit.py in that way? import logging ... logging.debug('\t__init__: name=[{!s}]'.format(self.name)) ...

I'm experiencing a quite funny issue, any time I invoke vulners.Vulners() my root logger getting reconfigured. So I am forced to delete added Handler any time I'm using the module.

Perhaps it will be a better solution to create a dedicated logger for the module and do not use root logger?

Thanks in advance.

nevermort commented 2 years ago

I'd be grateful if you update the PyPI package in case my PR is applicable and appropriate for you Thx.