vulpemventures / gdk-ocean

MIT License
2 stars 3 forks source link

`BlindPset` and `SignPset` implementation #7

Open louisinger opened 2 years ago

louisinger commented 2 years ago

This PR is not ready to be merged, two tests do not pass <--- now OK, see UPDATE comment below

domain refactoring

signing errros

About testing: the tests are launched on the testnet network in order to use the AMP assets. make test runs the tests. Only test_transaction_service.py is failing, other test files are OK. Both failing tests are skipped, u need to comment the @pytest.mark.skip line to run it.

grpc handlers not done

it closes #2 it closes #3 it closes #6

@altafan please review

louisinger commented 2 years ago

UPDATE: cc/ @altafan @tiero

Latest commits fix all the application layer and update to latest ocean stubs (no more submodule) + implement the grpc handlers. Those handlers has been testnet only manually with cli.py -> we should test in a real case before merging that PR in my opinion.

The branch is also bumping to gdk 0.56

It also removes the TEST_MNEMONIC hardcoded in tests file (now you need to set up a TESTNET_TEST_MNEMONIC env var locally, note that there is a support for .env files) -> the idea is to set up that variable via GH secret. Please send me private message if you want the test mnemonic.

add a ci.yml running the tests.

tiero commented 2 years ago

add a ci.yml running the tests.

make separate PR for for ci.yml and we merge that first, so this PR can run

tiero commented 2 years ago

add a ci.yml running the tests.

make separate PR for for ci.yml and we merge that first, so this PR can run

You can merge from master now, it shoudl trigger CI

tiero commented 2 years ago

CI is failing on make env?