Open louisinger opened 2 years ago
UPDATE: cc/ @altafan @tiero
Latest commits fix all the application layer and update to latest ocean stubs (no more submodule) + implement the grpc handlers. Those handlers has been testnet only manually with cli.py
-> we should test in a real case before merging that PR in my opinion.
The branch is also bumping to gdk 0.56
It also removes the TEST_MNEMONIC hardcoded in tests file (now you need to set up a TESTNET_TEST_MNEMONIC
env var locally, note that there is a support for .env files) -> the idea is to set up that variable via GH secret. Please send me private message if you want the test mnemonic.
add a ci.yml
running the tests.
add a
ci.yml
running the tests.
make separate PR for for ci.yml and we merge that first, so this PR can run
add a
ci.yml
running the tests.make separate PR for for ci.yml and we merge that first, so this PR can run
You can merge from master now, it shoudl trigger CI
CI is failing on make env
?
This PR is not ready to be merged, two tests do not pass <--- now OK, see UPDATE comment below
wally.psbt_blind
to implementTransactionService.blind_pset
method.gdk.psbt_sign
to implementTransactionService.sign_pset
method.wally.psbt_init
to implementTransactionService.create_empty_pset
.domain refactoring
gdk_wallet.py
+gdk_account.py
intogdk.py
file.Locker
instanciation outside of application layer (= remove async behavior fromcreate/login
methods).pin_data.json
signing errros
About testing: the tests are launched on the testnet network in order to use the AMP assets.
make test
runs the tests. Onlytest_transaction_service.py
is failing, other test files are OK. Both failing tests are skipped, u need to comment the@pytest.mark.skip
line to run it.test_send_pset
tries to send some blinded L-BTC from an address to another one. the test creates, blinds and signs the pset. It fails atgdk.psbt_sign
with "The tx failed the testmempoolaccept call with the node" error.test_send_amp_confidential_pset
tries to send some AMP asset from an address to another one. To pay the L-BTC fees, another account "fees" selects and signs an L-BTC input. It fails atgdk.psbt_sign
step "Tx contains unauthorized asset" -> not supported yet by GDK.grpc handlers not done
it closes #2 it closes #3 it closes #6
@altafan please review