vulpemventures / go-elements

Go support for Liquid/Elements transactions
MIT License
27 stars 12 forks source link

AddInReissuance various fix and improvements #210

Closed louisinger closed 1 year ago

louisinger commented 1 year ago

it closes #213

@altafan please review

altafan commented 1 year ago

@louisinger since #211 got merged, we can now update the BlindOutputs() function of the zkp generator and remove the issuanceBlidningArgs argument.

Since the spec states that in case an input has an issuance, it has to consider to be blinded if the blinded issuance flag is true OR UNDEFINED, I think it's worth adding a utility method IsIssuanceBlinded() to the partial input that makes sure to always return the correct value following the spec recommendation.

We would then use that function in BlindOutputs to know if an issuance is blinded and compute the correct token asset hash.

louisinger commented 1 year ago

add also fix to: #213 + several new tests cases