search

vulpemventures / marina

Liquid Wallet browser extension
MIT License
37 stars 19 forks source link

Rest in taxi #292

Closed bordalix closed 2 years ago

bordalix commented 2 years ago

Fixes #290

Access taxi services via REST (removes gRPC). Remove taxi-protobuf dependency. Throw response (and not response.data) on broadcastTx.

@tiero please review

tiero commented 2 years ago

testing on Chrome I am getting gRPC requires HTTP/2. This most likely beacuse you are not passing content type application/json. We multiplex on the same port many protocols and switch based on content type.

tiero commented 2 years ago

I tried to send 1USDt but seems it multiples wrongly to be used for coin selection

Error: Not enought coins to select 10000000049500000 f3d1ec678811398cd2ae277cbe3849c6f6dbd72c74bc542f7c4b11ff0e820958 (has: 316666666)
Screenshot 2022-01-21 at 11 08 50 Screenshot 2022-01-21 at 11 08 57
bordalix commented 2 years ago

I tried to send 1USDt but seems it multiples wrongly to be used for coin selection

Error: Not enought coins to select 10000000049500000 f3d1ec678811398cd2ae277cbe3849c6f6dbd72c74bc542f7c4b11ff0e820958 (has: 316666666)

Yes, yesterday I notice this also, but it seems to happen on master also (can you confirm?) so it seems not related with this PR. Also, I have an idea this is addressed on @louisinger PR.

tiero commented 2 years ago

werid since I can't test the taxi topup then

tiero commented 2 years ago

but it seems to happen on master also (can you confirm?)

master seems to have outdate taxi-protobuf, therefore cant ListAssets correctly and test taxi coin selection

bordalix commented 2 years ago

I'm working with @louisinger to have PR #244 stable (and with Taxi REST) in order for us to be able to test it and finally merge it.