vulpemventures / marina

Liquid Wallet browser extension
MIT License
39 stars 19 forks source link

add correct options to explorer dropdown in testnet #339

Closed bordalix closed 2 years ago

bordalix commented 2 years ago

closes #326

@tiero what do you mean with "weird behaviour"?

tiero commented 2 years ago

This fixes the list of options for regtest, but the still we have following problem:

Run this extension in browser clean

  1. Restore from menmonic
  2. Settings > Networks pick Testnet
  3. Setting > Explorers I asse Testnet as option still
image
tiero commented 2 years ago

Also, selectin Mempool is not using the right API URL, should be https://liquid.network/liquidtestnet/api instead of mainnet https://liquid.network/api

EDIT: also selecting back Blockstream will use the mainnet ones.

bordalix commented 2 years ago

@tiero 0c211bb should have fixed the issue of the explorers.

It's not a huge refactor, but you should review it.

Previously the app allowed for one to be on Testnet and use Blockstream mainnet explorer, which I believe was a bug.

There was a specific option called "Testnet" that used Blockstream testnet explorer, and there wasn't support for Mempool testnet explorer.

In a nutshell, now we have:

mainnet

testnet

regtest