search

vulpemventures / marina

Liquid Wallet browser extension
MIT License
37 stars 19 forks source link

Return "LDK compatible" utxos from `marina.getCoins` #342

Closed tiero closed 2 years ago

bordalix commented 2 years ago

@tiero trying to understand what "ldk compatible" means.

From the Telegram conversation, I think it means to add prevout and unblindData to the coins returned by marina.getCoins. If this is correct, it means we need to:

  1. Change the Utxo type on marina-provider by adding prevout and unblindData
  2. Merge, bump version, deploy, and then update dependency on marina
  3. Add missing keys to returned coins in marina.getCoins (we already have them on the returned JS object from selectCoins(account)(state)

Is this correct?

tiero commented 2 years ago

Correct! Proceed with marina-provider interface update and expose whole data

tiero commented 2 years ago

Merged and pushed to NPM