Marina CustomScript account

[louisinger]

This PR implements the new provider described here: https://github.com/vulpemventures/marina-provider/pull/20

It lets marina to send and receive funds on descriptors-based accounts.

Custom script account

The main change is the new CovenantAccount, implementing the Account interface via a new IdentityInterface. The CovenantIdentity is using a descriptors-like language to describe the account script type.

utxos and transactions updating is already handled by the current version of updater. The major change about this is the new selectedAccount member in the marina provider: it lets to implement new marina.useAccount, then updater and restorer in background work like the MainAccount ones. In Popup UI, "click on update" will launch an update for all the accounts.

Accounts are identified by their namespace or AccountID. The main account ID is a constant: "main". The covenant account ID aims to derive the wallet master key (using slip13). Thus, with mnemonic + namespace + template(s), the user is able to restore its covenants accounts.

User interface changes

This PR does not modify the UX but some changes are introduced by "multiple accounts paradigm":

• new settings/accounts page -> let u know what's the accounts set up on your extension.
• on main page, the balances values = sum of all accounts balances.
• on "send" page, balances values = sum of all auto-spendable accounts balances. auto-spendable means that marina can easily compute the sig needed to sign one of the account's coin. see script-analyzer.ts.
• no changes in receive, only main account addresses can be generated in popup.
• no changes in onboarding flow, to restore a covenant account u have to recreate it.

How to test

• build, install and onboard your mnemonic.
• visit vulpem.com or any other websites allowing you to run the marina provider.
• run marina.enable() if its the first time you are using the provider there.
• run marina.createAccount('test') -> will derive your mnemonic according to slip13. test is the new account ID.
• run marina.useAccount('test') -> switch from "main" to "test".
• run marina.importTemplate({ type: "marina-descriptors", template: "eltr($test, { asm($test OP_CHECKSIG), asm(OP_FALSE) })" })
• run marina.getNextAddress -> u have a taproot address, try to faucet it. the template contains $test OP_CHECKSIG which is an auto-spendable leaf so u can spend this coin in Popup (or using the provider).

ecclib.ts trick to bump LDK

TL;DR

• ecclib.ts shouldn't be imported in other src/*.ts files.
• tiny-secp256k1 will be replaced by the export of ecclib.ts via webpack.
• no changes for developer, he can use tiny-secp256k1 like a normal dependencie (but ecclib will be used under the hood).

In order to support BIP341 (or segwitv1) changes, we need to bump the latest LDK lib. This new version requires the injection of tiny-secp256k1 lib in some packages. The import * as ecc from 'tiny-secp256k1'; is doing that job.

However, the secp256k1 implementation works with wasm and marina extension is building three JS contexts: popup, background and content. for security reasons it is not possible to inject .wasm files directly in content scripts. That's why we need to import base64 wasm (.wasm files encoded as a base64 string which can be embedded in the javascript files).

To replace import 'tiny-secp256k1' by the "base64 wasm string" we are using the src/ecclib.ts file + webpack aliases. This is totally transparent for developers (import 'tiny-secp256k1` like the other dependencies).

it closes #320 it closes #322 it closes #321 it closes #318 it closes #325

@tiero @bordalix please review

[louisinger]

Independently of the network chosen, the extension is always trying to access http://localhost:8000/assets (taxi regtest url).

Right. I was thinking we do that already on master, will remove the regtest update on non-regtest networks

[bordalix]

Independently of the network chosen, the extension is always trying to access http://localhost:8000/assets (taxi regtest url).

Right. I was thinking we do that already on master, will remove the regtest update on non-regtest networks

Just to be clear, we do pool periodically (1 minute) taxi url. But we do it to the corresponding taxi url for the chosen network. The issue here is that it is ignoring the chosen network and always pooling the regtest url.

[tiero]

1. Build from this branch

yarn && yarn build && yarn web-ext:build

2. Tried restore an old menmonic, I got

burst exit include cactus remain orange stomach flash daring rabbit mandate web

PS: Same thing happens with "New Wallet" and click on "Remind me later"

[tiero]

WRT which account to use for change when cross-spending utxos accross accounts?

Best solution so far is to use the account chosen with useAccount API, below the equivalent UI component

[tiero]

Other feedback on UI: best to "hide" it in settings, switching address type/account is not really something user want to do often.

Also we should show the current used account in the receive tab and in send flow ("we using this $account for the change address)

[tiero]

@louisinger https://user-images.githubusercontent.com/3596602/169332441-326f4624-7363-4ab0-a5f4-20480f91c4fb.mov

[tiero]

Is Accounts tab in UI setting binded to actual account selector? I switched from test to main, and await marina.getSelectedAccount() is still returning metest

[tiero]

I get invalid template on marina.importTemplate("eltr($test, { asm($test OP_CHECKSIG), asm(OP_FALSE) })")

[louisinger]

Is Accounts tab in UI setting binded to actual account selector? I switched from test to main, and await marina.getSelectedAccount() is still returning metest

the settings/account selector let you choose the changeAccount not the "selected one". selectedAccount is a "local" variable in the webapp context, so each webapp has a different selectedAccount

[tiero]

There is some problems with incrementing the index of the derivation path, when calling importTemplate right before getNextAddress: if you try call th importTemplate and getNextAddress multiple time will return always the same index 1

[louisinger]

related PR: https://github.com/louisinger/marina/pull/1

[tiero]

on MainAccount f I do await marina.getAccountInfo() will get Uncaught Error: Account undefined not found