Marina Web Provider: Broadcast transaction

vulpemventures / marina

Liquid Wallet browser extension

MIT License

39 stars 19 forks source link

Marina Web Provider: Broadcast transaction #346

Closed bordalix closed 2 years ago

bordalix commented 2 years ago

Closes #341

When broadcasting a transaction:

inspects inputs to find own coins and lock them;
inspects outputs to find change addresses and credit it them.

@tiero please review

tiero commented 2 years ago

Should we need to add to marina-provider interface as well?

tiero commented 2 years ago

Can you make a build and attach here? so we ask other to test it out before merge

bordalix commented 2 years ago

Should we need to add to marina-provider interface as well?

PR https://github.com/vulpemventures/marina-provider/pull/23

bordalix commented 2 years ago

Can you make a build and attach here? so we ask other to test it out before merge

marina-0.4.5.zip

bordalix commented 2 years ago

do you think it is possible to isolate the logic you have implemented in broadcastTransaction and use it in the popup send flow ? we also broadcast a tx there at the end of the user journey (the idea is to remove the "uncomfirmedUtxos" logic in end-of-flow if possible)

Not 100% dry code, but better with 41fc7da

bordalix commented 2 years ago

Build for testing:

marina-0.4.5-RC2.zip