vulpemventures / marina

Liquid Wallet browser extension
MIT License
37 stars 19 forks source link

lightning network #349

Closed tiero closed 2 years ago

tiero commented 2 years ago

Overview

This propose a change to the UI/UX as specified in #255 and adds Lightning Network payments via Boltz submarine swaps. NOTICE: this is just a PoC, need serious work and cleanup to reach production.

How to test

Assuming you restore/create a wallet, pick password ciaociao you should be able to

  1. Select Testnet
  2. Click on Receive
  3. Select Liquid Bitcoin
  4. Select Lightning Network
  5. Enter an amount > 0.0005
  6. Pay an invoice with HTLC.me in
  7. After invoice paid, Marina will broadcast Liquid tx and after a minute you will have the new LBTC deposited

    TODOs

tiero commented 2 years ago

For the Submarine flow instead, I guess the new UX should be:

  1. Click on Send
  2. Select Liquid Bitcoin
  3. Select Lightning Network
  4. Enter an amount user want to withdraw > 0.0005
  5. Paste the LN invoice inside the next screen in marina
  6. Send the request to boltx which will answer with the lockup address
  7. Send L-BTC funds to that

After funds are locked onchain, Boltz will pay the invoice on our behalf

bordalix commented 2 years ago
  1. Enter an amount user want to withdraw > 0.0005

I believe there's also a max amount of 0.1 BTC on Boltz.

Do you confirm?

tiero commented 2 years ago
  1. Enter an amount user want to withdraw > 0.0005

I believe there's also a max amount of 0.1 BTC on Boltz.

Do you confirm?

Correct! We should shot those limits in the UI eventually/show errors