Fix address reuse if recipient asset !== L-BTC

vulpemventures / marina

Liquid Wallet browser extension

MIT License

37 stars 19 forks source link

Fix address reuse if recipient asset !== L-BTC #351

Closed louisinger closed 2 years ago

louisinger commented 2 years ago

The LDK fix lets us reuse the changeAddressGetter used in taxi pset. If the recipient asset is not L-BTC, a specific change address will be generated.

This PR also includes a small fix in txUpdater saga: now, we force re-updating of transactions where transfers.length === 0. It lets to fix bad Inbound/Outbound displaying in case of wallet with gap.

it closes #340

@tiero @Janaka-Steph please review

tiero commented 2 years ago

Shall we use ldk@next in marina? since we are going to support nicely liquidJS v6.x.x?

louisinger commented 2 years ago

Shall we use ldk@next in marina? since we are going to support nicely liquidJS v6.x.x?

I would wait #345 (to test if everything is working well with update)

tiero commented 2 years ago

Test are failing?

tiero commented 2 years ago

in case of wallet with gap.

Not sure problem happens for a gap limit reached TBH, I guess would happen anyway

tiero commented 2 years ago

having problem trying to restore seed with a build for production

Restoration failed
Unsuported witness version (undefined), only 0 (blech32) or 1 (blech32m) are supported

louisinger commented 2 years ago

included in #345