search

vulpemventures / marina

Liquid Wallet browser extension
MIT License
39 stars 19 forks source link

Make sure descriptor returned in getAccountInfo matches the one expected by neutrino-elements #367

Closed tiero closed 2 years ago

tiero commented 2 years ago

ststus of this? @louisinger

louisinger commented 2 years ago

related to https://github.com/vulpemventures/ldk/pull/128 (in order to get the same master xpub on neutrino-elements & marina)

tiero commented 2 years ago

Merged!

louisinger commented 2 years ago

@tiero I think also related to https://github.com/vulpemventures/marina/pull/361. The descriptor expected by neutrino-elements is wpkh("masterxpub") but #361 returns elwpkh($mainAccount).

I do think we should migrate to "el"-like template in neutrino-elements, or marina returns wpkh maybe? what about the token $mainAccount, let's drop it in favor of masterXPub ?

tiero commented 2 years ago

I do think we should migrate to "el"-like template in neutrino-elements

Yes this has been fixed already

what about the token $mainAccount, let's drop it in favor of masterXPub

Yes descriptor shoudl always be the final one, witohut template strings