address-amount form: handle asset precision - Githubissues

vulpemventures / marina

Liquid Wallet browser extension

MIT License

37 stars 19 forks source link

address-amount form: handle asset precision #409

Closed louisinger closed 1 year ago

louisinger commented 2 years ago

refacto the address-amount form (use Input component instead of HTLM input)
add a formik validation rule checking asset precision in amount field
move the SEND ALL button above the amount field (fix weird margin in case of error) -> need ACK on this @tiero

@tiero please review

it closes #406

tiero commented 2 years ago

amount less than 0 cant be typed @louisinger

https://www.loom.com/share/6d9dba2d6a734b90b22be8bb2d353ddf

tiero commented 1 year ago

UX still bit clunky:

allow me to enter more decimals than precision allows
allow me to enter strings

https://www.loom.com/share/5b8adad6e6ff4251b80579fb2bc1c6cb

Error messages should be more expressive ie.

too many decimals. Precision: 3
Not a valid number

tiero commented 1 year ago

SEND ALL does not work

https://www.loom.com/share/fb6d343ae63e48389a57470fd91d1792

tiero commented 1 year ago

I don't think replacing dots,commas is safe: like if someone is sending thousands, we may want to use the comma as thousands separator.

It's fine to let user type wrong stuff, we simply validate that, the error message should be more useful