vulpemventures / marina

Liquid Wallet browser extension
MIT License
37 stars 19 forks source link

LBTC tx used in contract creation don't show on tx list #445

Closed bordalix closed 1 year ago

bordalix commented 1 year ago

Related to #444

There were 2 contract creations on March 21 that don't show up here.

Screenshot 2023-03-21 at 15 59 39

tiero commented 1 year ago

Status? @louisinger

louisinger commented 1 year ago

Contract are shown under the fuji asset transactions list. From L-BTC point of view, borrow only moves coins from an account to another one (a kind of self-transfer) which is not displayed cause there is another asset in the tx (that's how marina "detects" self transfer tx).

I think the point here is how to identify correctly covenant-based transaction

tiero commented 1 year ago

I do think it's fine to show the L-BTC deposit into other accounts as "external" recipients for the time being

tiero commented 1 year ago

Closing, let me know if need to be re-open