search

vulpemventures / marina

Liquid Wallet browser extension
MIT License
37 stars 19 forks source link

`settings/accounts` Ionio restoration #452

Closed louisinger closed 1 year ago

louisinger commented 1 year ago

This PR adds a new page in settings/accounts with a form letting to restore Ionio accounts.

the restore process:

  1. creates the accounts if the wallet doesn't know them (that's why need the password input)
  2. persists the script details associated with Ionio artifacts
  3. triggers an update process on the restored scripts

it closes #440

@tiero @bordalix please review

bordalix commented 1 year ago

If I click Download without a previously created Ionio account, the button doesn't work and throws an exception.

Screenshot 2023-03-29 at 11 14 06

Screenshot 2023-03-29 at 11 14 39

tiero commented 1 year ago

How do I test the restoration if I can't dowload in the first place?

louisinger commented 1 year ago

How do I test the restoration if I can't dowload in the first place?

it was a WIP commit, my bad. Just pushed the final version with the Toast notification for error. cc/ @bordalix

tiero commented 1 year ago

Restoring at onboarding I have Marina hanging

tiero commented 1 year ago

also restoring JSON from Settings > Accounts hangs

image