search

vulpemventures / marina

Liquid Wallet browser extension
MIT License
37 stars 19 forks source link

skip OP_RETURN scripts while computing transfer #453

Closed louisinger closed 1 year ago

louisinger commented 1 year ago

This PR ensures that we are not adding the burn outputs value to "transfer" amount.

it closes #444

@tiero @bordalix please review

tiero commented 1 year ago

Shouldn't be shown as "burn" output instead of skip?

louisinger commented 1 year ago

Shouldn't be shown as "burn" output instead of skip?

Wdym by "output"? currently a burn tx of 25 L-BTC provided by your wallet will be shown as a -25 L-BTC (withdraw type). Before the PR it was shown as a self-transfer (+0 L-BTC)

EDIT: do u mean add an extra data "burnAmount" = the total number of OP_RETURN sats in the tx ?

tiero commented 1 year ago

EDIT: do u mean add an extra data "burnAmount" = the total number of OP_RETURN sats in the tx ?

Yep I meant that, but it's a new feature indeed, since as you say it was shown as a self-transfer