vulpemventures / marina

Liquid Wallet browser extension
MIT License
37 stars 19 forks source link

Show data about pset to sign inside `marina.signTransaction` popup #470

Closed louisinger closed 1 year ago

louisinger commented 1 year ago

This PR adds PsetView component to sign-pset.tsx popup.

Here is an example of a tx spending 2 utxos and sending some L-BTC to my mainAccountTest: image

Some changes on others files are related to a duplicate type UnblindedData. I've drop the duplicated types and use them from marina-provider. It's only about renaming "txID" to "txid" as defined in marina-provider.

it closes #421

@bordalix @tiero please review

tiero commented 1 year ago

Please use the design we already have, plus abstract UTXO complexity, so just show the outbound information like input value - change (mark non-main accounts as external for consistency)

Copy should maybe be Request you to SEND

pop-up - spend - 2 rows

bordalix commented 1 year ago

Things I don't like here:

  1. I'm not sending FUSD, I'm receiving
  2. Isn't it possible to show the ticker 'FUSD' instead of 0d86?
  3. Number format and alignment are making me nervous, damn OCD 😉

Screenshot 2023-04-13 at 12 18 08

cc @louisinger

louisinger commented 1 year ago

Things I don't like here:

  1. I'm not sending FUSD, I'm receiving
  2. Isn't it possible to show the ticker 'FUSD' instead of 0d86?
  3. Number format and alignment are making me nervous, damn OCD 😉

Screenshot 2023-04-13 at 12 18 08

cc @louisinger

This is not the expected behaviour, it should show you the ticker (but do not fetch it if it's the first time the wallet see the asset). I'll fix this

tiero commented 1 year ago

Number format and alignment are making me nervous, damn OCD 😉

Agreed with this. The figma should be the reference here I guess

tiero commented 1 year ago

I have an issue:

With this mint it should be shown the utxo amount - covenant output which is aroung 0.00110522

image
tiero commented 1 year ago

conflicts with master @louisinger

louisinger commented 1 year ago

I have an issue:

With this mint it should be shown the utxo amount - covenant output which is aroung 0.00110522

image

@tiero this should be fixed, now marina shows collateral+fees L-BTC.